Run the shipping web demo journey in Chromium CI - #1731
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
timohueser
force-pushed
the
codex/browser-demo-journey
branch
from
September 13, 2026 22:52
26bbc48 to
e6b4139
Compare
This was referenced Sep 13, 2026
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web demo CI built WebAssembly but never started a browser. The
wasmjob now runs one Chromium journey against the same Trunk output and embedded Grimsel assets. It selects Ride log, follows Save to Home, opens Rides and Ride detail with the device controls, switches to Load route and waits for Route received after reset, saves again, then reloads and completes a fresh demo.The suite observes existing readiness, screen and reset-status exports. It rejects page errors, failed resets, stalled transitions and missing or unchanged canvas output. Playwright 1.63.0 pins Chromium headless shell revision 1243 (153.0.8010.12). There is one worker, bounded state waits and no test retries. CI requires the journey step to succeed; a skipped step cannot pass. The same invocation writes native JUnit, browser diagnostics and failure screenshots/traces to
web-demo-browser-ATTEMPT.Validation:
NO_COLOR=true CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/Users/timo/Documents/OSM/target trunk build --config docs/Trunk.tomlpassed. Reused itsdocs/distfor the browser suite.npm test --prefix apps/obc-web-demo/tests/browser: 1 complete journey passed, 17.5 seconds (18.1 seconds total), Chromium 153.0.8010.12 on macOS. An earlier complete run passed before diagnostics persistence was added; the final run verified the retained evidence.python3 -m unittest discover -s tools/tests -v: 172 passed, including discovery, selection and aggregate-routing checks../tools/obc suites check,python3 tools/suite_registry.py validate-filters,./tools/obc test affected --base origin/develop --dry-run,actionlint .github/workflows/ci.yml,git diff --check.cargo fmt --all, pluscargo fmtin each standalone board, bootloader and desktop root.python3 docs/build_docs.py --check-linkspassed. Build/test instructions and testing policy changed in a separate docs commit; no production page or protected public copy changed.Deliberately omitted: a second Trunk build, native Rust tests/Clippy, the full CI mirror, broad UI snapshots, board/resource builds, and all physical tests. Existing native Demo/storage tests own exact saved-object counts, identities and sample bytes. This browser journey establishes page/WASM/renderer/control/reset integration only. PR #1694 and its production page remain separately owned.
Closes #1728. Merged as
ae46d3d3143af9288c530e4112aac1de3ae12ec9after independent review and run 34788058140 passed all required jobs and the aggregate for heade6b4139bf380f691cafa3e5811e5495a475edbcd. The downloaded browser artifact contains one passing case (18.141 seconds), 14 screen/reset observations and no errors. The earlier run was cancelled by the rebase after its browser job passed; final acceptance uses run 34788058140. Part of #1449 and #1448; other browser/application and physical acceptance obligations remain open.Independent adversarial review cleared the implementation and the final rebase delta at
e6b4139bf380f691cafa3e5811e5495a475edbcd. No blocking findings remain. No checks were repeated by the reviewer.