feat: open offline peak articles and photos from Peak View - #1849
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
timohueser
marked this pull request as ready for review
September 16, 2026 11:34
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result
In Peak View Browse, a selected summit with installed readable Wikipedia content shows a small information icon. Select opens its text, optional photo, and Sources. Back returns to the same summit, observer position, and heading. Peaks without content keep the existing Browse-to-Live Select action.
Peak articles use a distinct entry route and the shared article presentation. They do not expose Visit, landmark lists, or other search entry points. Lookup uses the summit's OSM SourceId and a map-generation-bound selection. Co-located summits retain distinct identities. The common UI-language, English, and baked-default fallback applies.
Panorama work releases the shared arena before photo decoding. Back regenerates the panorama from state kept outside scratch memory. This applies to the board, simulator, and cooperative web/iOS runtimes. Missing or failed photos keep text available. Failed text reads retry once per language change and remain latched between frames.
Validation
--all-targets -- -D warnings.--release --locked --features resource-reportpassed the board, allocation, init-frame, and compiler-invocation guards. No base build was run.git diff --checkpassed.App storage grows from 53,136 to 53,984 bytes (+848). OSM identity and alignment account for 768 bytes across the 64 permanent peak entries. All other 34 exact allocation records match. The shared arena remains 131,072 bytes. The measured residual main stack is 49,600 bytes, with 12,584 bytes above the recorded high-water value. Only the App allocation record changes; resource limits and hardware measurements stay unchanged.
Independent adversarial review found and resolved observer preservation in the cooperative host and language-change recovery after failed reads. Final review covers the measurement and snapshot records. Public behavior documentation is in a separate
docs:commit.No repeated screenshot sweep, repeated ARM build, full local CI mirror, or wake isolation was run. This change does not alter wake or scheduling behavior.
Remaining acceptance
No board is connected: the read-only board doctor found no debug probe, serial candidate, or J3 USB device. Physical scratch-memory and control acceptance remain outstanding in #1836. This PR does not close that issue or the parent epic on simulator evidence.
Normal regional Wikipedia acquisition and publication remain under #1805. The compatible published Baden-Württemberg maps retain their existing coverage and do not acquire Wikipedia content in this change.
Prerequisite #1846 is merged. Implements the software portion of #1836. Parent: #1830.
Final head:
2ef4146ac5601092db72f5db677579264e0b7e55. CI run 35089487768 and Bake run 35089487698 pass. The final merge from the prerequisite changes only the reviewed desktop test label and its README; feature source matches the measured and captured head.