Skip to content

feat: open offline peak articles and photos from Peak View - #1849

Merged
timohueser merged 23 commits into
developfrom
codex/peak-view-articles
Sep 16, 2026
Merged

timohueser merged 23 commits into
developfrom
codex/peak-view-articles

Conversation

@timohueser

@timohueser timohueser commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Result

In Peak View Browse, a selected summit with installed readable Wikipedia content shows a small information icon. Select opens its text, optional photo, and Sources. Back returns to the same summit, observer position, and heading. Peaks without content keep the existing Browse-to-Live Select action.

Peak articles use a distinct entry route and the shared article presentation. They do not expose Visit, landmark lists, or other search entry points. Lookup uses the summit's OSM SourceId and a map-generation-bound selection. Co-located summits retain distinct identities. The common UI-language, English, and baked-default fallback applies.

Panorama work releases the shared arena before photo decoding. Back regenerates the panorama from state kept outside scratch memory. This applies to the board, simulator, and cooperative web/iOS runtimes. Missing or failed photos keep text available. Failed text reads retry once per language change and remain latched between frames.

Validation

  • Complete App, host-core, and simulator suites passed. After review fixes, all 1,038 App tests and the complete 122-test host suite passed. Scoped Clippy passed with --all-targets -- -D warnings.
  • One final UI sweep rendered 268 frames. The 263 existing frames are unchanged. The five new frames cover the indicator, text, photo, Sources, and Back. The Back frame equals the initial selected-peak frame by design. These frames use real captured Mönch content in the supported map fixture.
  • One ARM head build with --release --locked --features resource-report passed the board, allocation, init-frame, and compiler-invocation guards. No base build was run.
  • All 86 firmware-tool tests, the suite registry, workspace and standalone Cargo formatting, public documentation links, render-key and screen-vocabulary guards, and git diff --check passed.

App storage grows from 53,136 to 53,984 bytes (+848). OSM identity and alignment account for 768 bytes across the 64 permanent peak entries. All other 34 exact allocation records match. The shared arena remains 131,072 bytes. The measured residual main stack is 49,600 bytes, with 12,584 bytes above the recorded high-water value. Only the App allocation record changes; resource limits and hardware measurements stay unchanged.

Independent adversarial review found and resolved observer preservation in the cooperative host and language-change recovery after failed reads. Final review covers the measurement and snapshot records. Public behavior documentation is in a separate docs: commit.

No repeated screenshot sweep, repeated ARM build, full local CI mirror, or wake isolation was run. This change does not alter wake or scheduling behavior.

Remaining acceptance

No board is connected: the read-only board doctor found no debug probe, serial candidate, or J3 USB device. Physical scratch-memory and control acceptance remain outstanding in #1836. This PR does not close that issue or the parent epic on simulator evidence.

Normal regional Wikipedia acquisition and publication remain under #1805. The compatible published Baden-Württemberg maps retain their existing coverage and do not acquire Wikipedia content in this change.

Prerequisite #1846 is merged. Implements the software portion of #1836. Parent: #1830.

Final head: 2ef4146ac5601092db72f5db677579264e0b7e55. CI run 35089487768 and Bake run 35089487698 pass. The final merge from the prerequisite changes only the reviewed desktop test label and its README; feature source matches the measured and captured head.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d4d3ab63-36aa-4c44-b442-1c5864ebed91


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@timohueser
timohueser marked this pull request as ready for review September 16, 2026 11:34
@timohueser
timohueser merged commit 5ae466a into develop Sep 16, 2026
28 checks passed
@timohueser
timohueser deleted the codex/peak-view-articles branch September 16, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant