examples/parallel/tufty: implement Displayer interface - #60
Merged
Merged
Conversation
Contributor
Author
|
@conejoninja @soypat small tweak so ST7789 implements Displayer |
Add the trivial SetPixel and Display stubs requested in the PR tinygo-org#55 review, plus a compile-time interface assertion. Fix the SetPixel interface comment typo.
davecheney
force-pushed
the
davecheney-displayer-stubs
branch
from
September 10, 2026 01:03
b0eb056 to
c35c3bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ST7789 already provides
Size, but the Tufty example's localDisplayerinterface was missing concreteSetPixelandDisplaymethods.This adds the two minimal stubs, asserts that
ST7789implementsDisplayer, and fixes theSetPizelcomment typo.SetPixeldelegates to the existing one-pixelFillRectangle;Displayremains a no-op because writes go directly to panel RAM.Validation:
gofmt -l rp2-pio/examples/parallel/tufty/tinygo build -target=tufty2040 -o /tmp/tufty-displayer-min.uf2 ./rp2-pio/examples/parallel/tufty