Skip to content

wasm: round sleepTicks up to a whole millisecond #5818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joeblew999 wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −1
Open

wasm: round sleepTicks up to a whole millisecond #5818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion targets/wasm_exec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,11 @@
"runtime.sleepTicks": (timeout) => {
// Do not sleep, only reactivate the scheduler after the given
// timeout, keeping exactly one pending wakeup.
const ms = Number(timeout) / 1e6;
// Round up to a whole millisecond. Some hosts (Cloudflare
// Workers) only advance the clock by a timer's delay rounded
// down to a millisecond, so a fractional remainder would be
// slept again and again without the clock ever moving.
const ms = Math.ceil(Number(timeout) / 1e6);
const due = Date.now() + ms;
if (this._scheduledWakeup !== undefined) {
if (this._scheduledWakeupDue <= due) return;
Expand Down