Repository navigation
ci: update the tinymemory pin exemption to the v1.17.0-based pin on main - #6798
Conversation
Updated the expected pin for the tinymemory module from v1.16.2 to v1.17.0, along with the corresponding reason text, to reflect the new base release. The pin remains at the release plus only the additional tinymemory-conversations crate, so the registry artifact still matches the compiled contract. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe ChangesPin exemption
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The CI exemption matches the current tinymemory pin, and no actionable merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
I’m a rabbit with a pin, Comment |
Summary
scripts/ci/check-module-pins.mjsfails onmainfor tinymemory:"tinymemory" drift has CHANGED since it was accepted. This PR updates the stale pin exemption so it matches the pinmainactually has.Why the exemption is stale
The #6781 and #6785 merges left
vendor/tinymemoryat0c754584, which describes asv1.17.0-4-g0c754584, and the registry record at v1.17.0. The exemption still expects the older #6785 pin,v1.16.2-3-g5e508b5a.Is the new drift safe?
Yes.
git diff --stat v1.17.0 0c754584in tinymemory adds only the new pure-library cratetinymemory-conversations(tinymemory#170), plus its workspace and lockfile entries: 20 files, additions only. There are no module, contract or bus source changes, so the registry's v1.17.0 artifact still matches the contract compiled here.Change
The tinymemory entry now expects
v1.17.0-4-g0c754584, and its reason text is updated. The entry is to be removed once #170 ships in a tinymemory release and both pins move to it.Verification
node scripts/ci/check-module-pins.mjs, with submodules unshallowed, no longer reports tinymemory.tinychannelsmismatch predates this PR and comes from test: drop 45 quarantined raw-coverage files, dedupe vendor-covered tests, repoint vendor pins #6781's pin bump. This PR leaves it alone.Summary by CodeRabbit