Skip to content

ci: update the tinymemory pin exemption to the v1.17.0-based pin on main - #6798

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:fix-tinymemory-pin-exemption
Sep 30, 2026
Merged

senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:fix-tinymemory-pin-exemption

Conversation

@senamakel

@senamakel senamakel commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Summary

scripts/ci/check-module-pins.mjs fails on main for tinymemory: "tinymemory" drift has CHANGED since it was accepted. This PR updates the stale pin exemption so it matches the pin main actually has.

Why the exemption is stale

The #6781 and #6785 merges left vendor/tinymemory at 0c754584, which describes as v1.17.0-4-g0c754584, and the registry record at v1.17.0. The exemption still expects the older #6785 pin, v1.16.2-3-g5e508b5a.

Is the new drift safe?

Yes. git diff --stat v1.17.0 0c754584 in tinymemory adds only the new pure-library crate tinymemory-conversations (tinymemory#170), plus its workspace and lockfile entries: 20 files, additions only. There are no module, contract or bus source changes, so the registry's v1.17.0 artifact still matches the contract compiled here.

Change

The tinymemory entry now expects v1.17.0-4-g0c754584, and its reason text is updated. The entry is to be removed once #170 ships in a tinymemory release and both pins move to it.

Verification

Summary by CodeRabbit

  • Chores
    • Updated the tracked version and compatibility notes for a pinned component. This is an internal maintenance change and does not alter application features or behavior for end users.

Updated the expected pin for the tinymemory module from v1.16.2 to v1.17.0, along with the corresponding reason text, to reflect the new base release. The pin remains at the release plus only the additional tinymemory-conversations crate, so the registry artifact still matches the compiled contract.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 543b2dba-f022-494b-b005-a26a2e8e6d6c

📥 Commits

Reviewing files that changed from the base of the PR and between 2069d2c and 507279d.

📒 Files selected for processing (1)
  • scripts/ci/module-pin-exemptions.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The tinymemory module-pin exemption now expects v1.17.0-4-g0c754584. Its reason compares the pin with v1.17.0 and describes the included crate and workspace-entry changes.

Changes

Pin exemption

Layer / File(s) Summary
Update the tinymemory exemption
scripts/ci/module-pin-exemptions.json
The expected pin changes to v1.17.0-4-g0c754584. The reason now identifies v1.17.0 as the comparison base and describes the crate and workspace-entry changes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: m3ga-mind

Merge Risk: ⚪ Minimal · up to 50727

The CI exemption matches the current tinymemory pin, and no actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 50727

The change affects 1 system.

Changed systems: scripts

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — scripts (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in scripts/ci/module-pin-exemptions.json: The tinymemory exemption’s expected pin changes from v1.16.2-3-g5e508b5a to v1.17.0-4-g0c754584; its reason updates the comparison base from v1.16.2 to v1.17.0 and specifies the crate and workspace-entry changes in the pin.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the CI tinymemory pin exemption to the v1.17.0-based pin on main.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

I’m a rabbit with a pin,
A newer tag is tucked within.
The crate is named, the base is clear,
No module, contract, or bus changes here.
I nibble clover, hop away,
And leave the exemption neat today.

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel merged commit d6ea0b0 into tinyhumansai:main Sep 30, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant