Repository navigation
Conversation
Updated the pinned commit for the tinytools vendored dependency to incorporate upstream changes. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 1 minute for your next included review. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
Summary
Update the TinyTools parser submodule to recover tool calls inside an unterminated text
<tool_call>when DeepSeek emits JSON arguments followed by DSMLparameter namemetadata. It also preserves calls that carry their name inside the JSON object and keeps prose after the DSML calls wrapper. Parsing JSON boundaries first means tag-like argument text such as</script>remains data.The parser change is in tinyhumansai/tinytools#37; this PR updates the vendored TinyTools gitlink to that branch commit.
Closes #204
Validation
cargo fmt --check— passedcargo build --workspace --all-targets— passedcargo clippy --workspace --all-targets -- -D warnings— passedcargo test --workspace— passedcargo test --manifest-path vendor/tinytools/Cargo.toml -p tinytools-agent— passed (374 tests)cargo clippy --manifest-path vendor/tinytools/Cargo.toml -p tinytools-agent --lib --all-features -- -D warnings— passedcargo clippy --manifest-path vendor/tinytools/Cargo.toml -p tinytools-agent --all-targets --all-features -- -D warnings— blocked by the existingmanual_assert_eqlint atcrates/tinytools-agent/src/parse/test/regressions.rs:130; workspace clippy above passedScope
The recovery is limited to the malformed DeepSeek DSML name-parameter shape in the text
<tool_call>parser. This does not add new diagnostics; upstream TinyAgents already handles diagnostics and bounded retries for unparsed text calls.