Skip to content

fix: target Tiny Humans direct System One route - #5

Merged
senamakel merged 1 commit into
mainfrom
openrouter-followups
Sep 20, 2026
Merged

senamakel merged 1 commit into
mainfrom
openrouter-followups

Conversation

@senamakel

@senamakel senamakel commented Sep 20, 2026

Copy link
Copy Markdown
Member

Summary

  • route the Tiny Humans OpenRouter configuration to the deployed direct System One endpoint
  • retain TypeSafe and direct OpenRouter endpoint paths independently
  • cover the composed Tiny Humans request path with the local transport test

Live verification

  • one paid typed JEV Noul request to POST /agent-integrations/openrouter/systemone returned HTTP 200 and a resolved typesafe/jev-* response

Verification

  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo build --all-targets --all-features
  • cargo test --all-features
  • cargo deny check all

Summary by CodeRabbit

  • Documentation

    • Updated Tiny Humans OpenRouter documentation to reference the current System One endpoint.
    • Synchronized client configuration and specification examples with the updated endpoint path.
  • Bug Fixes

    • OpenRouter requests now route directly through the correct System One endpoint.
    • Preserved the default endpoint behavior for other client configurations.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@tinysweeper

tinysweeper Bot commented Sep 20, 2026

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: 66db2de72ac0
Updated: 1789928250 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 2 Active findings 0
Tests 1 Noted findings 0
Documentation 3 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["...stem_one_and_accepts_a_resolved_jev_model<br/>changed"]:::changed
  n1["Client<br/>changed"]:::changed
  n2["ClientConfig<br/>changed"]:::changed
  n3["evaluate"]:::impacted
  n4["request"]:::impacted
  n5["config"]:::impacted
  n6["server"]:::impacted
  n7["...sponse_validation_report_failure_metadata"]:::impacted
  n8["authentication_is_terminal"]:::impacted
  n0 -->|calls| n3
  n0 -->|tests| n3
  n0 -->|calls| n4
  n0 -->|tests| n4
  n0 -->|calls| n6
  n0 -->|tests| n6
  n1 -->|uses| n2
  n5 -->|uses| n2
  n7 -->|calls| n3
  n7 -->|tests| n3
  n7 -->|calls| n4
  n7 -->|tests| n4
  n7 -->|calls| n5
  n7 -->|tests| n5
  n7 -->|calls| n6
  n7 -->|tests| n6
  n8 -->|calls| n3
  n8 -->|tests| n3
  n8 -->|calls| n4
  n8 -->|tests| n4
  n8 -->|calls| n5
  n8 -->|tests| n5
  n8 -->|calls| n6
  n8 -->|tests| n6
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 6 files; 0 findings. _The code index is behind this pull request (indexed at `417356c685e6`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The endpoint-path refactor correctly separates provider base URLs from their System One paths, including the TinyHumans proxy route. The change looks safe to merge. 3 files were not security-reviewed: README.md (prose or tabular data), crates/tinyjevclient/src/client/README.md (prose or tabular data), docs/specs/system-one-client.md (prose or tabular data). _The code index is behind this pull request (indexed at `417356c685e6`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

tests

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change updates the TinyHumans OpenRouter proxy endpoint path by removing the `/v1` segment, moves the path from a module constant to a `ClientConfig` field, and updates documentation and tests accordingly. The behaviour shift is intentional and fully covered by the diff's tests. No defects introduced. _The code index is behind this pull request (indexed at `417356c685e6`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The PR correctly retargets the Tiny Humans OpenRouter client path to the direct System One endpoint: constants are added, the tinyhumans_openrouter constructor now uses the explicit System One path, the debug formatter exposes it, the README is updated to match, and the transport test now asserts the new path. The change is small, consistent, and safe to merge; I found no problems within the diff. _The code index is behind this pull request (indexed at `417356c685e6`), so retrieved context may be out of date._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No end-to-end harness in this repository: no e2e test files and no e2e workflow.
Evidence and run details
  • Models: ladder/vectors, gpt-5.6-luna, deepseek-v4-flash, deepseek/deepseek-v4-flash
  • Spend: $0.008584
  • Tokens: 140477 input · 6006 output · 19668 cached · 422 embedding
Head State Pass summary
66db2de72ac0 ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1789928250)

tinysweeper 0.1.0

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-20T18:12:48.287065Z 66db2de PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c6604b57-5fc3-4f9e-af69-e49d177db0b3

📥 Commits

Reviewing files that changed from the base of the PR and between 9b0f90c and 66db2de.

📒 Files selected for processing (6)
  • README.md
  • crates/tinyjevclient/src/client/README.md
  • crates/tinyjevclient/src/client/mod.rs
  • crates/tinyjevclient/src/client/test.rs
  • crates/tinyjevclient/src/client/types.rs
  • docs/specs/system-one-client.md
 _________________________________
< Ripgrepping your code for bugs. >
 ---------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel merged commit e53d5f0 into main Sep 20, 2026
9 of 10 checks passed

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0086 · 140,477 in / 6,006 out · 19,668 cached (14%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash, deepseek/deepseek-v4-flash · 422 embedded
critique:    $0.0062 · 90,583 in  / 1,782 out · 10,317 cached (11%) · gpt-5.6-luna
security:    $0.0017 · 27,945 in  / 451 out   · 1,878 cached (7%)   · gpt-5.6-luna
tests:       $0.0003 · 13,337 in  / 2,551 out · 0 cached (0%)       · deepseek-v4-flash
description: $0.0001 · 4,879 in   / 100 out   · 4,001 cached (82%)  · deepseek/deepseek-v4-flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant