feat(collect): route feishu browser and mcp, drop four channels - #189
Open
titanwings wants to merge 2 commits into
Open
titanwings wants to merge 2 commits into
titanwings wants to merge 2 commits into
Conversation
D5 option b. Feishu --mode browser and mcp reach their modules. discord, notion, reddit, and gmail leave the contract channel list.
CHANNEL_MODES omitted dingtalk, so collect dingtalk --mode browser was rejected as collect/usage before the consent gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
D5 选项 b。飞书
--mode browser与--mode mcp必须到达对应模块。discord、notion、reddit、gmail 不再是契约渠道。丢掉的--mode不再静默变成 api。钉钉--mode browser必须到达模块里的同意门。栈停在 dot-skill-test，dot-skill 保留。Scope
CHANNELS与--help的 usage 行来自同一张表，为 feishu、slack、dingtalk、x。--mode。非法值退出 2，codecollect/usage，remedy 列出合法值。回执mode等于用户给的值。collect feishu --mode browser没有同意时退出 2，status 为 waiting-for-user-consent，补救步骤指向distilly consent grant --scope collect:feishu:browser。collect dingtalk --mode browser没有同意时退出 2，status 为 waiting-for-user-consent。collect feishu --mode mcp在空 HOME 下失败原因是feishu_config.json，不是--chat-id。collect/unknown-channel，remedy 为known channels: feishu, slack, dingtalk, x。collect feishu --mode <api|browser|mcp>写在命令代码块外。放进代码块会让 entry-surface 把 mode 枚举和渠道枚举比成同一组，产生不能写入基线的新 finding。Blast Radius
slack 仍不接受
--mode。collect slack --mode browser退出 2，codecollect/usage，remedy 为legal --mode values: none。tests/consent.test.mjs未改。钉钉模块仍只支持 api 与 browser。Verification
T03、T04、T05、T06、T07、T08、T18、T19、T20 由红转绿。
node scripts/run-gates.mjs --id audit-tests。基线父 SHA 为 9c8f1ce。之前 Node 22.14.0 输出ratchet failing 22, baseline 22，门禁 PASS，6.3s。之后 Node 22.14.0 在 cd99139 输出ratchet failing 13, baseline 13，7.8s。Node 20.20.2 同样是ratchet failing 13, baseline 13，8.2s。删掉的 audit-tests 基线是全部九行
R08。剩 13 行数据。未删 R16、R17、R23、R24、R28、R38、R48、R49、R56、R58。删掉的 entry-surface 基线九行。
剩 5 行 finding。
node scripts/run-gates.mjs --id entry-surface在 Node 22.14.0 与 Node 20.20.2 都是 RESULT PASS。node scripts/run-gates.mjs --without playwright。Node 22.14.0 为 8/8。Node 20.20.2 为 8/8。npm test为 379 条，失败 0 条，cancelled 0。Node 22.14.0 与 Node 20.20.2 都是如此。Node 22.14.0 上
DISTILLY_PLAYWRIGHT_ROOT=/tmp/pw-root node scripts/run-gates.mjs --requires playwright为 3/3。三条 acceptance 都是 18/18 通过。us-house 含FAIL · units=2744 speakers=18 attributed=175。You see，Node 22.14.0，head cd99139。
collect --help第一行是distilly collect <feishu|slack|dingtalk|x> [options] [--json]。collect discord --json退出 2，remedy 为known channels: feishu, slack, dingtalk, x。collect feishu --mode browser --json退出 2，mode 为 browser，status 为 waiting-for-user-consent。collect feishu --mode mcp --json的 mode 为 mcp，错误是 no credential at ~/.distilly/feishu_config.json，不含--chat-id。collect dingtalk --mode browser --json退出 2，status 为 waiting-for-user-consent。Rollback
回退 cd99139 与 2435fbe 即恢复四个渠道与旧的静默 api 降级。栈停在 dot-skill-test，dot-skill 保留。