fix(blind-test): resolve relative --out before spawning distilly - #194
Open
titanwings wants to merge 1 commit into
Open
titanwings wants to merge 1 commit into
titanwings wants to merge 1 commit into
Conversation
HANDOFF §8 uses --out run and --a split/A.srt. Those relatives were re-resolved against the harvest/retrospect cwd, so the ledger landed off-tree and prepare exited 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
HANDOFF §8 与盲测 RUNBOOK 用相对路径
prepare --a split/A.srt --out run。脚本把--base-dir work传给子进程,同时把 cwd 也设成run/work。相对路径被再解析一次,账本写到run/work/run/work,随后retrospect找不到knowledge/index.json,prepare 退出 1。T23 就是这条红。数据形状如下。
mktemp -d里cd,split-corpus --out split --ratio 0.7,再prepare --a split/A.srt --person lin-gong --out runnode scripts/blind-test.mjs prepare …run/profile.html存在--person blind-sample-01 --baselinerun/profile.html存在--outsplit-corpus --ratio 0.7效果数字不是代码。本拍不跑三模型盲测 Lane 7 与 Lane 8。第一组数字由后续 swarm 按 RUNBOOK 的模型约束写到 store 的
media/distilly-atomic-pr/pr-8-blind/。Scope
scripts/blind-test.mjs对--out、--a、--view、--scores做一次path.resolve(process.cwd(), …)。harvest、retrospect、view check、view render拿到的--base-dir与文件路径都是绝对路径。tests/blind-test.test.mjs加一条相对--out用例,覆盖 prepare、finalize、control、score。docs/v2/BLIND-TEST-RUNBOOK.md写明三角色必须是三个不同模型,都不是 deepseek-flash。裁判是claude-sonnet-5-thinking-medium。核对者是gpt-5.6-sol-medium。蒸馏者不得是这两个。第一组数字的落地路径写进 RUNBOOK。tests/gates/baseline/audit-tests.txt只删这一行。blind-test prepareworks with the relative --out the handoff (§8) and the blind-test README use该行对应
tests/audit/effect-hosts.test.mjs的 T23。T22、T24 保持绿。基线数据行从 16 减到 15。不删 R08、R21、R23、R28、R48、R58。不改
src/derive/retrospect.mjs。不把 PR-6 合并进来。父提交已含 PR-2 的回指校验。Blast Radius
绝对路径路径仍然走 T24,行为不变。相对路径从崩变成能写出
profile.html。acceptance 18/18 不变。栈停在 dot-skill-test,dot-skill 保留。Verification
T23 由红转绿。T22、T24 保持绿。基线从 16 行减到 15 行。
改前,Node v22.14.0,HEAD d05717b:
T23 失败原文(同一 HEAD 上直接跑 HANDOFF 命令,退出 1):
新用例
accepts the relative --out and --a the handoff (§8) uses在同一 HEAD 上失败:改后,Node v22.14.0,HEAD 2b8b22f:
改后,Node v20.20.2:
node scripts/run-gates.mjs --without playwright在 Node v20.20.2 与 Node v22.14.0 都是 8/8 gates passed。npm test是 # tests 404、# fail 0。DISTILLY_PLAYWRIGHT_ROOT=/tmp/pw-root node scripts/run-gates.mjs --requires playwright在 Node v22.14.0 上是 3/3 gates passed。三份语料都是验收结果:18/18 通过。us-house 含FAIL · units=2744 speakers=18 attributed=85。You see,Node v22.14.0。
mktemp -d里cd后按 HANDOFF §8 跑相对路径。split-corpus --out split --ratio 0.7退出 0。prepare --a split/A.srt --person lin-gong --out run退出 0。run/profile.html53715 字节。新用例在 head 上
node --test tests/blind-test.test.mjs tests/audit/effect-hosts.test.mjs是 # tests 13、# fail 0。三条 R56 都 ok。本拍不跑 Lane 7 与 Lane 8,正文不贴效果命中率。
Rollback
git revert 2b8b22fde9bd41fe9e6ab5d854efd2e91b2da4d8。基线那一行会回来,相对--out再次退出 1。