Make URLs in chat messages tappable - #64
Closed
MrSurly wants to merge 1 commit into
Closed
Conversation
Extends the existing #hashtag/@mention token parser in ChatMessageText to detect http(s):// and www. URLs, trimming trailing sentence punctuation from the tappable span. Tapping opens the link via url_launcher in the external browser.
Contributor
Author
|
Superseded by #73, which merges this branch in alongside the other rolled-up issues. |
MrSurly
added a commit
to MrSurly/MeshCore-TEAM
that referenced
this pull request
Jul 19, 2026
PR tmacinc#68 and tmacinc#64 each added this key independently; git's merge kept both non-conflicting insertions, which silently dropped the key from codegen entirely. Removed the duplicate and regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatMessageTextto also detect http(s):// and www. URLs, trimming trailing sentence punctuation (period, comma, etc.) from the tappable span.url_launcher.couldNotOpenLinkstring (en/de) shown if launching fails.url_launcherfor https links.