Skip to content

README: cross-family review up front, the overseer, numbers from the real ledger - #10

Merged
tomastaker merged 4 commits into
mainfrom
docs/readme-foreman
Sep 1, 2026
Merged

README: cross-family review up front, the overseer, numbers from the real ledger#10
tomastaker merged 4 commits into
mainfrom
docs/readme-foreman

Conversation

@tomastaker

@tomastaker tomastaker commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Problem

The README led with "shape first", buried the one thing no other skill offers (the other model family reviews the diff, on subscriptions you already have), linked T3 Code to the chat product, and carried a "shared blind spots" claim with no evidence behind it.

Solution

  • Rewritten README in a persona voice (an ancient-Egyptian overseer with two gangs, whip and papyrus tally, in the ponytail spirit): hook first, before/after on one example, Numbers, How it works with a light/dark SVG flow, per-host install, a commands table, FAQ including "who this is not for". T3 Code badge now points at pingdotgg/t3code.
  • Numbers come from the author's real ledger (20 Aug – 1 Sep 2026, ten repositories): 46 cross-family reviews of real diffs, 17 with at least one high-severity finding, medians per family. bench/ledger-stats.sh prints the same table from any ledger, so the numbers are reproducible per user.
  • assets/: hand-cut logo (light and dark), two SVG diagrams.
  • bench/seeded-review/: a small planted-defect harness (4 diffs × 2 reviewers) with its pilot results. Both families caught 8/8 planted defects, so the pilot is kept as a harness, not cited as evidence in the README.
  • CI shellchecks the two bench scripts.

Checks

  • All five test suites pass locally (47/52/27/13/25), delivery.sh --race 20: 0 duplicates, 0 lost.
  • bench/ledger-stats.sh reproduces every number in the README table from the local ledger.
  • run.sh dry-run against a stub agent-run: repo build, branches, worktrees, launches and collection execute.
  • Both SVGs and both logo variants inspected in light and dark, on GitHub.

Limits

  • Ledger findings are as returned by the reviewer, not adjudicated; the README says so.
  • The logo is generated (Seedream), cut to transparent PNG by hand.

🤖 Generated with Claude Code

…ch с заложенными багами

README переписан: первые строки продают ревью другой семьёй на своих подписках,
голос персонажа (прораб с двумя бригадами), Before/after на одном примере,
раздел Numbers с честными результатами эксперимента и счётчиками тестов,
схема потока (SVG, светлая и тёмная), Install по хостам, таблица команд, FAQ
с «кому не подходит». Ссылка T3 Code ведёт на pingdotgg/t3code.

bench/seeded-review: четыре диффа с двумя заложенными дефектами каждый,
бриф, раннер, список дефектов и сырые результаты 8 прогонов от 2026-09-02
с ручной оценкой. CI прогоняет shellcheck по run.sh.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: c159af4a-4147-4ffe-99c3-1dfbe3f80197


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T23:33:53.569639Z 054fc35 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

tomastaker and others added 2 commits September 2, 2026 02:32
…откие строки

Подпись лежала на пересечении стрелок, строка про SEQUENTIAL вылезала за
рамку, стрелка от координатора упиралась в границу блока.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 054fc351ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1,97 @@
diff --git a/review/01-pagination.diff b/review/01-pagination.diff

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove earlier cases from each seeded diff

Starting with case 02, applying this file also adds the entire previous benchmark diff as review/01-pagination.diff; cases 03 and 04 recursively include all earlier cases in the same way. Reviewers are therefore given progressively larger changes containing defects from other test cases, despite the benchmark describing each input as one isolated source/spec/test change. A reviewer can report or be influenced by earlier planted defects, corrupting per-case scoring and timing, so regenerate cases 02–04 directly against the clean base.

Useful? React with 👍 / 👎.

wt="$WORK/wt/$n"; git worktree add -q "$wt" "$n"
sed -e "s#__NAME__#$name#g" -e "s#__WT__#$wt#g" -e "s#__DIFF__#$diff#g" "$HERE/brief.md" > "$WORK/$n.brief.md"
for backend in claude codex; do
id="$(node "$AR" run --role reviewer --backend "$backend" --cwd "$wt" --brief "$WORK/$n.brief.md" --detach --timeout 25 </dev/null | node -e 'let s="";process.stdin.on("data",d=>s+=d).on("end",()=>console.log(JSON.parse(s).id))')"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Disable cross-family fallback for benchmark runs

When any of these eight concurrent reviews hits a usage or rate limit, this invocation uses agent-run's default automatic fallback. The checked wrapper at skills/delegate-kit/scripts/agent-run:1031-1043 marks the requested run failed-quota and launches the other backend under a new ID, while this script waits for and copies only the original ID. The fallback result is therefore lost and the named family has no usable result, undermining the family comparison; pass --fallback none for these benchmark runs.

Useful? React with 👍 / 👎.

Comment on lines +36 to +37
cp "$HOME/.delegate-kit/runs/$3/result.json" "$OUT/$1-$2.json" 2>/dev/null || echo "no result for $1 $2 ($3)"
echo "$1 $2: $(node -e 'const r=require(process.argv[1]);console.log(r.findings.length+" findings")' "$OUT/$1-$2.json" 2>/dev/null || echo failed)"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove stale result files before collecting a rerun

When the output directory already exists—normally when rerunning the benchmark on the same day—and a worker produces no result.json, the failed cp leaves the previous $OUT/$1-$2.json untouched. The next line then parses that stale file and reports its finding count as if it came from the current run, silently mixing experiments. Delete each destination before launch or fail the run when collection fails.

Useful? React with 👍 / 👎.

@tomastaker tomastaker changed the title README: cross-family review up front, the foreman voice, seeded-review bench README: cross-family review up front, the overseer, numbers from the real ledger Sep 1, 2026
…п в стиле ponytail

Персонаж заменён на египетского надсмотрщика с плетью и папирусом; схема и
текст переведены на «gangs» и «tally». Раздел Numbers больше не цитирует
пилот с заложенными багами (обе семьи нашли 8 из 8, преимущества он не
показывает): вместо него таблица из ledger автора за 20.08–01.09.2026,
46 кросс-вендорных ревью реальных диффов, 17 с high-находкой.
bench/ledger-stats.sh печатает ту же таблицу из любого ledger.
Логотип: чёрно-белый рисунок, вырезан на прозрачный фон, светлый и тёмный.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@tomastaker
tomastaker merged commit 250897f into main Sep 1, 2026
5 checks passed
tomastaker added a commit that referenced this pull request Sep 7, 2026
README: cross-family review up front, the overseer, numbers from the real ledger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant