Require --author-backend for reviewer and verifier - #9
Merged
Conversation
Автор молча подставлялся из implementer'а пресета. Diff, написанный самим координатором на Claude под auto, получал автора codex, ревьюера claude и пометку independent: true — ревью того же семейства выдавалось за независимое (воспроизведено через route --role reviewer --parent claude без флага). Теперь route и run для reviewer и verifier требуют --author-backend claude|codex|self; при явном --backend на run автор не нужен. SKILL.md §6, README, roles.md, review.md — команда без квадратных скобок. Тесты: 5 проверок. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ует автора По ревью PR #6 (Codex P1 ×2): исключение для явного --backend действовало и на route, где по автору считается independent — теперь только для run; resume ревьюера/верификатора падал на проверке автора — семейство берётся из meta прогона. Тесты: 3 проверки, включая resume через заглушку CLI. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #6, which GitHub closed when its stacked base branch was deleted after #5 merged. Same commits.
Problem
resolveRoutedefaulted the author of a diff to the preset's implementer. A diff the coordinator wrote itself on Claude underautowas therefore attributed tocodex, routed to aclaudereviewer, and markedindependent: true— a same-family review reported as independent. Reproduced withroute --role reviewer --parent claudeand no flag. SKILL.md §6 showed--author-backend selfin square brackets, so the coordinator had no reason to pass it.Change
routeandrunrefuse--role reviewer|verifierwithout--author-backend claude|codex|self; an explicit--backendonrunneeds no author, since the family is already named and independence is not computed there.roles.md,review.md: the flag is part of the command,selfwhen the coordinator wrote the diff.tests/route.sh: 5 refusal/pass-through checks (48 total).Checks
route.sh48/48,caps.sh43/43,delivery.sh25/25,node --check, SKILL.md 7977 bytes.🤖 Generated with Claude Code