feat: Some random modifications - #31
Merged
Merged
Conversation
On iOS a Kotlin/Native framework is self-contained static binary, so the HTTP engine must be linked into it at build time, whereas on Android/JVM the engine is resolved from the app's runtime classpath. Thus this change.
jzitnik-dev
force-pushed
the
modifications
branch
from
August 1, 2026 19:32
97cddbf to
ae29b04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small modifications that aren't worth multiple PR's.
Darwin build is a self-container binary so Ktor's client has to be linked, and can't be access from runtime classpath like in android.
Gradenow forteacherusesTeacherReferenceinstead ofName.It doesn't make sense to use
Namewhich is name of a subject as explained in javadoc. (I was thinking about renamingNametoSubjectNamebut decided not to just to not break existing usage)Teacherobject now has fullRoomReferenceand not just room name.Self-explanatory