Repository navigation
fix(v99): honest native unlock errors, real desktop recovery reset, unclipped bulk bar - #5
Merged
Merged
Conversation
β¦nclipped bulk bar D-01: classifyNativeError matched 'VALID' inside "...inVALID master password...", so every wrong password showed "Some of the values entered were not valid." unlock_vault also leaked the raw VaultError Display text; it now uses safe_error. Exact-message/prefix classification keeps AUTH_FAILED, INVALID_FORMAT, TAMPERED, IO and CRYPTO_FAILED distinct. D-02: native .pmv vaults have no recovery-key slot, yet the modal offered a 24-char key form; Fresh Reset cleared only localStorage and sent the user straight back to "Welcome back". Add Rust reset_vault (timestamped archive + bounded prune + session clear), resetVaultForForgotPassword() for both backends, and an honest native-only recovery UI. Browser recovery-key behaviour is untouched. D-03: FloatingBulkBar was fixed bottom-8 z-[70] over the z-[60] mobile nav: measured 36px overlap at 700x1000 and x=-132..522 clipping at 390x844. .floating-bulk-bar CSS lifts it above the nav, caps its width, wraps on phones and keeps the desktop pill. Tests: 45th/46th harnesses + 2 Playwright specs. RED 12+19 harness FAIL, 4/4 Playwright FAIL, 2 FAIL against reverted 722affc; GREEN 46/46 harness, 182/182 Playwright (11.6m). Gates: tsc 0, verify 0, node20 46/46, audit 0, live 5/5, rustfmt 23/23. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V-99 β "nothing is working": Windows photo RCA + fixes
Provenance check (not a stale-binary artefact). Current
mainis722affc(PR #4 merged). LiveLatestisv2.5.2-beta.1, published2026-11-09T18:36:11Z, target071e407whose parent is2280e33(Batch 1β7 head) β so the beta already contains all previous work.gh apion that ref confirmssrc/lib/platform.tsstill hadupper.includes('VALID')andVaultHome.tsxstill hadbottom-8. All three defects below are present inmainitself.D-01 β wrong password reported as "Some of the values entered were not valid."
classifyNativeError()matched the substringVALID, which appears in"Authentication failed: **invalid** master password ..."and"File header is **invalid** ...". Rustunlock_vaultwas also the last storage command returning rawVaultErrorDisplay text, whilesafe_error()emits only fixed messages (never code strings) β soAUTH_FAILED/INVALID_FORMAT/TAMPERED/IO/CRYPTO_FAILEDwere unreachable in the UI. The lock screen additionally fired a success haptic on failure.Fix: exact-message + known-prefix classifier (structured codes still accepted; genuine Tauri
invalid value:staysVALIDATION),unlock_vaultusessafe_error(&e), unlock errors prefererr.safeMessage, no success haptic on failure.D-02 β "Forgot master password? Recover vault" was a dead end
The 24-character recovery key is WebCrypto/localStorage-only: the Rust
VaultFileHeaderhas no recovery slot,create_vault(..., None)passes none,createNewVault()'s native branch ignores itsrecoveryKeyargument, andrecoverVaultWithRecoveryKey()reads onlylocalStorage. Worse, "Fresh Reset" cleared onlylocalStorage, leaving the real.pmvfile β so the app returned to "Welcome back" with the same unopenable vault.Fix: new Rust command
reset_vault(timestamped archive oflocal-vault.pmv, bounded to 3 archives, session/vault_path cleared);resetVaultForForgotPassword()selects the native command or the browser archive path and clears the stale native flag; the modal detectsisNativeRuntime(), hides the impossible key tab, explains why, and starts on the one working path. Browser recovery-key behaviour and its tests are unchanged.D-03 β clipped / overlapping bulk-action bar
FloatingBulkBarwas a 654pxflexrow atfixed bottom-8 z-[70]whileMobileNavisz-[60]at the same bottom (lg:hidden). Earlier audits only covered 360Γ800 / 1440Γ900 and never selected an item.23..677 / 922..968, nav932..990β 36px overlap12..688 / 860..906β 26px gapx=-132..522, Delete right476 > 390, 36px overlapx=12..378, Delete right240, all actions visible, 26px gap373..1067β fine373..1067Fix:
.floating-bulk-barCSS β94pxmobile /32pxdesktop offset (plus--safe-bottom),width: max-content+ viewport cap, phone wrap / β₯640px single-row pill, non-shrinking children. A 24px Android inset gives computedbottom: 118pxwith no overlap.RED β GREEN
native-error-classification: RED 12 FAIL β GREEN 20/20 PASSnative-recovery-bulk-bar: RED 19 FAIL β GREEN 37/37 PASS (imports the real bundled modules, including a mockedwindow.__TAURI_INTERNALS__.invokefor native reset)vault-bulk-bar-layout.spec.ts: RED 4/4 FAIL β GREEN 4/4vault-unlock-error-native-reset.spec.ts: 2 FAIL against reverted722affcβ 2 PASS on the fixplatform-built.mjsadded toscripts/build-test-bundles.mjsFinal gates β zero regressions
npx tsc --noEmit0 Β·npm run verify0 (46/46 harness, WCAG contrast, 23 Rust files formatted, bundle budget) Β·node@20 scripts/run-harness.mjs46/46 Β·npm audit --audit-level=high0 Β·check-live-release.mjs5/5 Β· fullnpx playwright test182 passed (11.6m) Β· push CI42849591867success (2/2 jobs).Not done by this agent
No merge, tag, signing or publication. These fixes are not in
v2.5.2-beta.1; a new signed Beta/final build (4 secrets +keytool+ Windows runner + signed-log gate) is required before the user's Windows.exeshows them.