Skip to content

fix: unblock Dependabot updates with stale PR base metadata - #30

Merged
tonyputi merged 2 commits into
mainfrom
fix/29/dependabot-base-metadata
Nov 17, 2026
Merged

tonyputi merged 2 commits into
mainfrom
fix/29/dependabot-base-metadata

Conversation

@pullsmith-by-tonyputi

Copy link
Copy Markdown
Contributor

Summary

Closes #29

  • Remove the comparison against cached pull-request base.sha. The actual base branch is still reread and compared before every write; base name/repository, default branch, eligibility and head guards are preserved.
  • Allow GitHub at most three additional mergeability metadata reads, separated by two-second waits. Persistently unknown state still defers; API errors are not retried.
  • Keep the single repository-scoped App token, expected_head_sha, serial processing, conflict/check handling, required checks and human approval unchanged.
  • Pin the extracted script to immutable source commit 202126a and update current behavior documentation.

Regression evidence

  • Before the fix: 52 existing temporary self-checks passed and the new stale-base regression failed as expected (0 writes rather than 1).
  • After the fix: 57 temporary self-checks pass, including stale cached PR base SHA, real branch/head/default-branch races, initially unknown and persistently unknown mergeability, eligibility loss while waiting, and no retries on API errors.
  • PASS: yamllint, actionlint on affected workflows, ShellCheck on existing scripts, node --check, git diff --check, and pinned-download/local-script byte comparison.
  • No permanent tests, CI test jobs, new dependencies or settings changes are added.

Live finding and follow-up

myki#59 and myki#60 report cached PR base.sha 4fa3df89e5c9670935ffc170b09b8b369fe2317e while actual main is ec5d46c0c5d5a4d11c087ffe6891ef16ad49581a. The previous guard therefore defers eligible PRs indefinitely. Evidence: https://github.com/tonyputi/myki/actions/runs/44091650353 .

myki#58 has a genuine conflict and must remain blocked. Earlier owner branch rewrites and native merge of myki#57 are not evidence of this updater doing branch writes.

After owner review/merge, repin the myki consumer and repeat real observation under tonyputi/myki#61. No real branch update using this fix is claimed yet. No approvals, manual merges, force pushes, credentials or protection changes were performed.

@tonyputi
tonyputi merged commit a7aa478 into main Nov 17, 2026
3 checks passed
@tonyputi
tonyputi deleted the fix/29/dependabot-base-metadata branch November 17, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: unblock Dependabot updates when PR base metadata is stale

1 participant