setup: Pass user arguments to the tool verbatim - #9
Merged
Merged
Conversation
The invocation function joined its arguments into a single string and ran that through eval, so the shell parsed them a second time: quoted file names were split on spaces, semicolons turned into command separators and globs were expanded. Only the generated Docker arguments need eval, since they carry constructs such as "$(pwd)"; user arguments now reach the tool as positional parameters, untouched. Signed-off-by: Rogerio Guerra Borin <rogerio.borin@toradex.com>
rborn-tx
force-pushed
the
fix-arg-parsing
branch
from
September 17, 2026 01:15
42da6ec to
3270464
Compare
Collaborator
Author
|
@lucas-akira I'm merging this PR so that you can use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invocation function joined its arguments into a single string and ran that through eval, so the shell parsed them a second time: quoted file names were split on spaces, semicolons turned into command separators and globs were expanded.
This should fix the situation...