Derive published package version from release tags - #3
Merged
Conversation
Contributor
Author
|
@codex review |
ggoodman
marked this pull request as ready for review
July 16, 2026 02:47
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release pipeline combined two incompatible contracts:
mainpacked the source placeholder version (0.0.0-dev) into the immutable artifact, while the release workflow required the GitHub tag to match that placeholder exactly. A real release therefore required committing a publish version into the development manifest, instead of deriving publish metadata from the release.The intended contract is the same one used by our other packages:
mainowns the verified build payload, while the release tag owns the published version.What changed
mainas an immutable, SHA-bound package payload rather than the final published packagev<semver>release tagmainartifact before packagingpackage.jsonThe source
package.jsonremains0.0.0-dev. The only release-time package-content change is its derivedversion; the compiled code, declarations, README, and license come from the exact verifiedmainartifact.Validation
node scripts/check-github-actions-pinned.tsnpm run typechecknpm test— 9 passing testsnpm run buildnpm pack --dry-run@torkbot/code-mode-sandbox@0.1.0package.jsonexcluded — no payload differencesnpm publish <derived tarball> --dry-run --ignore-scripts --access publicgit diff --check