Expose a direct Sandbox runtime factory - #4
Merged
Conversation
ggoodman
marked this pull request as ready for review
July 16, 2026 14:58
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createSandboxNodeRuntimeHostseam withcreateSandboxNodeRuntimeSandboxInstancelifecycle while making the Node host composition internal.torkbot/rootfs.qcow2and mount the workdir read-only with/.git,/.torkbot, and/node_modulesmaskedWhy
The previous API required every caller to construct
Node24Runtimewith the return value of a Sandbox host factory. That exposed an internal ownership boundary without adding useful caller composability. This package owns the integration, so it should return the completed runtime while callers continue to own and configure the Sandbox itself.This intentionally replaces the 0.1 API rather than preserving a compatibility alias.
Validation
npm run typechecknpm test(9 tests)npm run buildnpm pack --dry-run --ignore-scriptsgit diff --check