Repository navigation
Support dynamic virtual camera resolution - #19
Conversation
- Update VirtualCameraSender.gd to support dynamic resolution setting and update protocol to send Width and Height headers. - Update holistic_tracker.py to receive Width and Height headers and re-initialize pyvirtualcam on resolution change. - Update TrackingUI.gd to inform VirtualCameraSender when resolution changes. - Update test_protocol.py to reflect the protocol change.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR enables changing the Virtual Camera resolution from the UI. Previously, the resolution was hardcoded to 640x360.
The TCP protocol for video frames has been updated to include explicit Width and Height fields (4 bytes each) before the image data, ensuring the receiver (Python) correctly reshapes the buffer.
The Python receiver now detects resolution changes and restarts the virtual camera instance as needed.
PR created automatically by Jules for task 13276402467538714730 started by @toxicoder