Skip to content

Move Win32 file dialog defs into type, const, and proc sections - #190

Merged
treeform merged 1 commit into
masterfrom
move-win32-filedialog-defs
Sep 6, 2026
Merged

Move Win32 file dialog defs into type, const, and proc sections#190
treeform merged 1 commit into
masterfrom
move-win32-filedialog-defs

Conversation

@treeform

@treeform treeform commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Move OPENFILENAMEW, the OFN_* flags, and GetOpenFileNameW / GetSaveFileNameW into the existing type, const, and imported-proc sections in windefs.nim.
  • Drop the extra importc on those two procs so they inherit importc, stdcall from the single file-wide push/pop, same as the other Win32 APIs.

Test plan

  • nim c examples/filedialogs.nim, examples/alertdialog.nim, and tests/test.nim
  • Run examples/filedialogs.exe: O opens, S saves, cancel returns empty paths
  • Skim the windefs.nim section order (types, then consts, then one importc proc block)

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@treeform
treeform merged commit c60e3da into master Sep 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant