Correct browser text input and wheel direction - #194
Open
relh wants to merge 2 commits into
Open
Conversation
relh
changed the title
relh
marked this pull request as ready for review
September 9, 2026 04:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Emscripten backend cancels printable
keydownevents while relying on the resultingkeypressforonRune. Chrome then suppresses that event: Backspace works in a canvas text field, but typing a replacement name inserts nothing. Allow the printable default only when rune input is enabled and Ctrl/Meta are absent; the existing keypress handler still delivers and consumes the rune.The browser wheel handler also used opposite signs for Mac and non-Mac hosts. Normalize both to the existing Mac direction while preserving their magnitude multipliers. This lets a downward wheel gesture scroll a Silky panel down on Linux-hosted Chrome.
The same real key-event flow fails at name entry on unmodified Windy (baseline) and passes name entry with this fix (browser run). That second run continued through dropdowns, theme selection and reward gating, then exposed the wheel-direction bug fixed here. Both fixes then passed the complete native/WebGL UI gallery workflow, including real key presses, slider drags beyond both bounds, dropdowns, disabled reward actions, resizing and downward scrolling. The consumer pins this PR at
d38903c295fdbb74e46bda70c3d6b892195d95c3.The final commit passed Linux, macOS and Windows CI. IME composition, clipboard input and native wheel conventions are outside this change.