Prevent synchronization mutex leak - #316
Merged
Merged
Conversation
Prior to this change it was possible for the lock to be taken and never released if `Thread.raise` or similar happens between the successful `try_lock` and `begin`. It's not so easy to reproduce, but in production we've been occasionally seeing individual workers getting repeated `Trilogy::SynchronizationError` and never recovering. I debugged a bit and the lock was held by the main thread, and the error also happened on the main thread. We've got some poorly placed `Timeout.timeout` calls that I suspect are triggering this.
byroot
approved these changes
Aug 18, 2026
composerinteralia
force-pushed
the
prevent-synchronization-mutex-leak
branch
from
August 18, 2026 11:01
b50eb7c to
f859b80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change it was possible for the lock to be taken and never released if
Thread.raiseor similar happens between the successfultry_lockandbegin.It's not so easy to reproduce, but in production we've been occasionally seeing individual workers getting repeated
Trilogy::SynchronizationErrorand never recovering. I debugged a bit and the lock was held by the main thread, and the error also happened on the main thread. We've got some poorly placedTimeout.timeoutcalls that I suspect are triggering this.