Repository navigation
Conversation
| } | ||
|
|
||
| export type DraftAutoModelOption = { | ||
| enabled: boolean; |
There was a problem hiding this comment.
🟡 Low: Code Quality Violation
Prop name 'enabled' is not prefixed with `is` or `has` (...read more)
Enforces a consistent naming pattern for boolean props to ensure that the variable is prefixed with either is or has (or the uppercase equivalent). Any prefix symbol (_, $, etc) is allowed.
Helpful? 👍/👎
🚩 Report as false positive. Flags the rule for review to improve detection accuracy.
| * Whether Auto mode can be selected in the model picker. Enabled when model routing is on and the user has a model | ||
| * in every routing cluster; absent means Auto mode cannot be selected. | ||
| */ | ||
| auto?: { enabled: boolean }; |
There was a problem hiding this comment.
🟡 Low: Code Quality Violation
Prop name 'enabled' is not prefixed with `is` or `has` (...read more)
Enforces a consistent naming pattern for boolean props to ensure that the variable is prefixed with either is or has (or the uppercase equivalent). Any prefix symbol (_, $, etc) is allowed.
Helpful? 👍/👎
🚩 Report as false positive. Flags the rule for review to improve detection accuracy.
|
| * Whether Auto mode can be selected in the model picker. Enabled when model routing is on and the user has a model | ||
| * in every routing cluster; absent means Auto mode cannot be selected. | ||
| */ | ||
| auto?: { enabled: boolean }; |
| }: { | ||
| tenant_id: string; | ||
| store: IModelProviderStore; | ||
| }): Promise<RoutableModel[]> { |
There was a problem hiding this comment.
Why do we still have RoutableModel type? Didn't we generalise and add all new attributes to Model type as discussed
| tenant_id: string; | ||
| store: IModelProviderStore; | ||
| }): Promise<RoutableModel[]> { | ||
| const models = await store.listModels({ tenant_id, include_catalog_info: true }); |
There was a problem hiding this comment.
do we need include_catalog_info param? Always include?
GET /api/v1/capabilities reports auto.enabled when model routing is on for the tenant and the user has a model in every routing cluster. The picker offers Auto, selectable only when that capability is enabled. Co-authored-by: Cursor <cursoragent@cursor.com>
…capabilities when listing models fails The composer's model button shows the selected model's reasoning effort, as in the design. A failed model listing now fails the capabilities request, so clients keep their last known capabilities instead of dropping a selected Auto. Co-authored-by: Cursor <cursoragent@cursor.com>
2bbfc5e to
6613762
Compare
5bf4136 to
2efa923
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2efa923. Configure here.
…e empty state when Auto matches the search Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

Summary
Part of AGE-2853
Stacked on #1443 (auto model selection for the root thread), so this diff shows only the capability and the UI.
Changes
GET /api/v1/capabilitiesreportsauto.enabled: true when model routing is on for the tenant and the user has a model in every routing category. Core addscanRouteEveryCategory.auto.enabledis true; otherwise it shows "Auto mode is not available for now".listRoutableModelsis shared by turn routing and the capability check.AutoCapabilitytype.How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Adds a required capabilities field and eligibility logic tied to model routing and catalog coverage; UI changes how model and reasoning effort are selected and reconciled in drafts.
Overview
GET /api/v1/capabilitiesnow includes requiredauto.enabled, set when tenant model routing is on and the user's catalog covers every routing cluster (via new core helpercanRouteEveryCategory). OpenAPI and the TS/Python SDKs pick upAutoCapability.The new-chat model picker adds an Auto row at the top; it is only selectable when
auto.enabledis true, otherwise it is disabled with a short hint. Selecting Auto commits a dedicated patch that clears all model params. Draft reconciliation treatsautolike other capability-gated choices viakeepsAutoModel.Reasoning effort moves out of a separate composer control and into the model list: each eligible row shows an effort label and an edit menu (
DraftReasoningEffortMenu), including a Default option that clearsreasoningEffort. The builder/agent model editor passes no Auto option and no inline reasoning controls.Reviewed by Cursor Bugbot for commit d3f57b8. Bugbot is set up for automated code reviews on this repo. Configure here.