Repository navigation
NAS-145296 / 27.1.0 / replace flake8 with ruff and format the code with ruff (by yocalebo) - #114
Merged
Merged
Conversation
Ruff runs the same pyflakes and pycodestyle rules as flake8 and passes on the current code. Its settings now live in pyproject.toml, so tox.ini is no longer needed. The job keeps the name lint so existing required checks still match. (cherry picked from commit 39bc21b)
Author
|
Automatic cherry-pick failed. Please resolve conflicts by running: If the original PR was merged via a squash, you can just cherry-pick the squashed commit: |
Author
This is the output of ruff format with its default settings. One type ignore comment moved with its argument so mypy still applies it. (cherry picked from commit debb1ae)
Pull requests now fail when a new or changed Python or Markdown file does not match ruff format. Files a pull request does not touch are not checked. (cherry picked from commit 572acdb)
yocalebo
marked this pull request as ready for review
November 17, 2026 17:58
yocalebo
approved these changes
Nov 17, 2026
Author
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces flake8 with ruff and formats the code with ruff.
ruff checkreplaces flake8 in the lint job. It runs the same pyflakes and pycodestyle rules. Its settings now live inpyproject.toml, sotox.iniis removed.ruff formatusing its default settings. One type ignore comment moved with its argument so mypy still applies it.ruff format --checkon the Python and Markdown files a pull request adds or changes. Files the pull request does not touch are not checked, so a new ruff release that formats differently will not fail unrelated pull requests.astral-sh/ruff-action. The job keeps the namelint, so existing required checks still match.The formatting commit is large but changes no behavior. The other two commits are easiest to review on their own.
Original PR: #113