Add bundle, bazel-bep, and constants to workspace members - #1154
Merged
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
These three crates were already implicit workspace members (cargo auto-includes path dependencies inside the workspace directory), so this is a no-op for cargo itself. But external tools that read the root member list literally — notably the Nix-based resolver used to build trunk2's Rust workspace, which consumes these packages as a git dependency — cannot find non-listed packages. Listing them explicitly fixes that resolution. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
dfrankland
force-pushed
the
add-implicit-workspace-members
branch
from
July 30, 2026 16:55
308afc7 to
372fe8c
Compare
TylerJang27
approved these changes
Jul 30, 2026
acatxnamedvirtue
approved these changes
Jul 30, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1154 +/- ##
==========================================
+ Coverage 82.97% 83.21% +0.24%
==========================================
Files 71 71
Lines 16044 16044
==========================================
+ Hits 13312 13351 +39
+ Misses 2732 2693 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
bundle,bazel-bep, andconstantsto the rootCargo.toml's[workspace] memberslist.Why
These three crates were already implicit workspace members — cargo automatically includes path dependencies that live inside the workspace directory and aren't in
exclude— so this change is a no-op for cargo itself (Cargo.lockis unchanged).However, external tooling that reads the root member list literally cannot see them. Specifically, trunk2 (
rs/Cargo.toml) consumes six packages from this repo as a git dependency (bazel-bep,bundle,codeowners,constants,context,proto), and its Nix-based resolver (cargo-nix-plugin) resolves packages via the root workspace's member list rather than scanning the repo. It fails on the three unlisted crates:members— an external consumer resolves this repo's packages through the root member list, so removing them again (e.g. while tidying the list) silently breaks trunk2's Nix build even though plain cargo keeps working.rspec-trunk-flaky-tests/is intentionally left as-is: it's a Ruby gem extension crate and not consumed by trunk2.Verification
cargo metadata --no-depssucceeds from the repo root and frombundle/cargo check --workspace --all-targetspassesCargo.lockunchanged (no resolution/feature-unification changes)taplo fmtclean🤖 Generated with Claude Code