[pull] master from php:master#1118
Merged
Merged
Conversation
The self-signed certificate the FTP test server presents (ext/ftp/tests/server.inc) was generated in 2016 with a ten-year validity and expired on 2026-07-23, so ext/ftp/tests and the ftps:// stream tests (ext/standard/tests/streams/opendir-003 and -004) fail the TLS handshake with "certificate expired" on every branch. Regenerate it as a self-signed CN=127.0.0.1 certificate that expires 2099-12-31, so the suite does not silently break again on a ten-year cadence.
* PHP-8.2: Regenerate the expired ext/ftp/tests/cert.pem (#22873)
* PHP-8.3: Regenerate the expired ext/ftp/tests/cert.pem (#22873)
* PHP-8.4: Regenerate the expired ext/ftp/tests/cert.pem (#22873)
* PHP-8.5: Regenerate the expired ext/ftp/tests/cert.pem (#22873)
This reverts commit fa47ae1. On macOS in GitHub Actions, pthread_jit_write_protect_supported_np() returns false. So, there's really no point in running JIT with it in the first place. We'll still need to tweak some tests when they explicitly enable the JIT.
* PHP-8.2: [skip ci] Revert "CI: Enable JIT testing on Apple Silicon ZTS 8.6+"
* PHP-8.3: [skip ci] Revert "CI: Enable JIT testing on Apple Silicon ZTS 8.6+"
* PHP-8.4: [skip ci] Revert "CI: Enable JIT testing on Apple Silicon ZTS 8.6+"
* PHP-8.5: [skip ci] Revert "CI: Enable JIT testing on Apple Silicon ZTS 8.6+"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )