Repository navigation
fix(stdlib): load honours its chunkname in errors and tracebacks - #427
Closed
shinyobjectz wants to merge 1 commit into
Closed
shinyobjectz wants to merge 1 commit into
shinyobjectz wants to merge 1 commit into
Conversation
load(chunk, chunkname) ignored chunkname, so every error raised in a loaded chunk read "-no-source-:N: ...". Now the chunk takes its name as Lua's luaO_chunkid shows it: "@file" is the file, "=name" is used as is, any other string is [string "its first line"]. A syntax error is prefixed with the same name. Without a chunkname nothing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load(chunk, chunkname)ignoredchunkname, so any error raised inside a loaded chunk read-no-source-:N: .... Hosts that load files throughload, for example arequirebuilt over a virtual filesystem, can't tell a user which file failed.This passes the chunk name to the compiler as Lua's
luaO_chunkidshows it:"@file"→file"=name"→name[string "its first line"]A syntax error from
loadis prefixed with the same name. Without a chunkname, behaviour is unchanged.Tests are in
test/language/load_test.exs. The full suite passes (2874 passed).