Wire --spacer to $spacer in root tokens - #42927
Open
julien-deramond wants to merge 1 commit into
Open
julien-deramond wants to merge 1 commit into
julien-deramond wants to merge 1 commit into
Conversation
$root-tokens hardcoded --spacer: 1rem instead of interpolating $spacer. Every --spacer-N token derives from $spacer through the $spacers map, so overriding $spacer moved the scale but left the base token stuck at 1rem. Other tokens in the same map already interpolate their Sass variable (e.g. --border-width), so this brings --spacer in line with that convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
$root-tokenshardcodes--spacer: 1reminstead of interpolating#{$spacer}. This changes it to--spacer: #{$spacer}, matching how neighboring tokens in the same map (e.g.--border-width: #{$border-width}) already work.Motivation & Context
$spaceris the base of the spacing scale and is meant to be overridable. Every--spacer-Ntoken is generated from the$spacersmap, which itself derives from$spacer, so overriding$spacermoves the whole scale. But--spaceritself stayed at1remregardless, because it was never wired to the variable it's named after. Anyone readingvar(--spacer)directly after overriding$spacerwould silently get a stale value.Found while auditing v6-dev's custom-property/Sass-variable philosophy against julien-deramond/bootstrap-tokens#11.
Type of changes
Checklist
npm run lint)Live previews
Related issues
🤖 Generated with Claude Code