Rename datetime edit minute pseudo-element - #42935
Open
kataokatsuki wants to merge 1 commit into
Open
kataokatsuki wants to merge 1 commit into
kataokatsuki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #42140 from v6.
::-webkit-datetime-edit-minutedoesn't match any element in Chromium or WebKit, which both name the minute field::-webkit-datetime-edit-minute-field. As a result, the minute field keeps the browser's defaultpadding: 1px, while the hour, day, month and year fields getpadding: 0(#42007, #42052).On the Browserslist question raised in #42052: both names are non-functional
::-webkit-pseudo-elements, which Selectors 4, Appendix B requires browsers to treat as valid at parse time, so the rename shouldn't affect how the rest of this selector list is parsed. I've only measured the result in Chrome 152: in the built CSS, the minute field's computed padding goes from1pxto0, the same as the hour field.