Repository navigation
Conversation
Fixes #186. Ports DSpace#6378 to prevent failures caused by GitHub runner Chrome updates.
There was a problem hiding this comment.
🟢 Approval recommended
The workflow change is compatible with the locked Cypress version, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates CI browser provisioning to address runner Chrome-related e2e failures without changing Cypress test code.
Changes:
- Replaces apt-based Chrome installation with
browser-actions/setup-chrome@v2. - Selects
chrome-for-testingfor Cypress runs. - Removes obsolete Chrome version configuration comments.
| File | Description |
|---|---|
.github/workflows/build.yml |
Installs Chrome for Testing and selects it for e2e tests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Fixes #186. Since GitHub's Ubuntu runner image updated Chrome from 154 to 155 on 2026-10-13, e2e tests fail on every scheduled and PR build, even on the unchanged commit
d4868c36a8.Analysis
Port of the CI part of upstream DSpace#6378 (
.github/workflows/build.ymlonly):apt-get"Install Chrome" step and the unusedCHROME_VERSIONcomment.browser-actions/setup-chrome@v2(Chrome for Testing) before the e2e step.browser: chrometobrowser: chrome-for-testing.Problems
Cypress code is intentionally untouched. If this change alone does not fix the e2e failures, the DiscoJuice login wait in
cypress/support/commands.tswill be fixed in a follow-up.Sync verification
N/A (no translation files changed).
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
N/A (verified by this PR's CI run).
Copilot review