Skip to content

Reduce number of plasma profile elements from 501 to 101#4416

Merged
je-cook merged 6 commits into
mainfrom
4301-make-full-profile-output-in-mfile-optional
Jul 24, 2026
Merged

Reduce number of plasma profile elements from 501 to 101#4416
je-cook merged 6 commits into
mainfrom
4301-make-full-profile-output-in-mfile-optional

Conversation

@timothy-nunn

@timothy-nunn timothy-nunn commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@timothy-nunn
timothy-nunn requested a review from a team as a code owner July 6, 2026 14:52
@timothy-nunn timothy-nunn linked an issue Jul 6, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.64%. Comparing base (84679f5) to head (e703700).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/plot/summary.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4416      +/-   ##
==========================================
- Coverage   48.64%   48.64%   -0.01%     
==========================================
  Files         151      151              
  Lines       29703    29704       +1     
==========================================
  Hits        14449    14449              
- Misses      15254    15255       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe

Copy link
Copy Markdown
Collaborator

@timothy-nunn May as well change the value of n_plasma_profile_elements down to 100 here also

@timothy-nunn

Copy link
Copy Markdown
Collaborator Author

@timothy-nunn May as well change the value of n_plasma_profile_elements down to 100 here also

I would probably opt to do that in another PR since it will cause massive regression failures

@je-cook

je-cook commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

I dont see the need for this option being exposed on the main process cli, especially as the MFILE is explicitly the machine readable version. I prefer the option of reducing the number of points recorded. This is surely only talking about 121kB (31entries*500points*8bytes) / 1024 to 12kB assuming 7 char per entry?

@timothy-nunn
timothy-nunn force-pushed the 4301-make-full-profile-output-in-mfile-optional branch from f64a035 to 6aa7141 Compare July 24, 2026 08:04
@timothy-nunn timothy-nunn changed the title Allow detailed physics profile output to be switched off Reduce number of plasma profile elements from 501 to 101 Jul 24, 2026
@timothy-nunn
timothy-nunn requested a review from a team July 24, 2026 08:05
@je-cook je-cook added the Profiles Relating to the plasma profiles label Jul 24, 2026

@mkovari mkovari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tim, Can you confirm that the plots haven't changed significantly?

@chris-ashe
chris-ashe self-requested a review July 24, 2026 09:11
@chris-ashe

Copy link
Copy Markdown
Collaborator

Having inspected the changes on unit tests we are getting a difference on the line averaged values only at the 7th significant figure which is completely fine. The other profile values are all analytically calculated.

@je-cook

je-cook commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Ok, just the unit test failure needs fixing then

@timothy-nunn
timothy-nunn force-pushed the 4301-make-full-profile-output-in-mfile-optional branch from 0b26d09 to e703700 Compare July 24, 2026 14:21
@timothy-nunn

Copy link
Copy Markdown
Collaborator Author

We opted to go with 201 elements not 101. We observed that the fusion power changed 1.3% with 101 elements for the large tokamak eval test. With 201 elements this different halved to 0.52%. Me and @chris-ashe were happier with this smaller change and so opted to have slightly more profile elements.

@je-cook je-cook left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy

@je-cook
je-cook merged commit f4541d8 into main Jul 24, 2026
8 of 11 checks passed
@je-cook
je-cook deleted the 4301-make-full-profile-output-in-mfile-optional branch July 24, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Profiles Relating to the plasma profiles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make full profile output in MFILE optional

5 participants