Reduce number of plasma profile elements from 501 to 101#4416
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4416 +/- ##
==========================================
- Coverage 48.64% 48.64% -0.01%
==========================================
Files 151 151
Lines 29703 29704 +1
==========================================
Hits 14449 14449
- Misses 15254 15255 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@timothy-nunn May as well change the value of |
I would probably opt to do that in another PR since it will cause massive regression failures |
|
I dont see the need for this option being exposed on the main process cli, especially as the MFILE is explicitly the machine readable version. I prefer the option of reducing the number of points recorded. This is surely only talking about 121kB |
f64a035 to
6aa7141
Compare
mkovari
left a comment
There was a problem hiding this comment.
Hi Tim, Can you confirm that the plots haven't changed significantly?
|
Having inspected the changes on unit tests we are getting a difference on the line averaged values only at the 7th significant figure which is completely fine. The other profile values are all analytically calculated. |
|
Ok, just the unit test failure needs fixing then |
0b26d09 to
e703700
Compare
|
We opted to go with 201 elements not 101. We observed that the fusion power changed 1.3% with 101 elements for the large tokamak eval test. With 201 elements this different halved to 0.52%. Me and @chris-ashe were happier with this smaller change and so opted to have slightly more profile elements. |
No description provided.