6 make identifier column name agnostic#9
Open
bdgregg wants to merge 2 commits into
Open
Conversation
… corrected Google Args validation, fixed bug in copy_xslx_to_batch and replaced the save_xslx_as_csv call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated make-batch-dirs to allow for custom 'id' column name. Also updated the sample config file and the README.md to reflect the code changes. Added a new config/parameter of id_column/--id-column to allow specifying what the object id column is. Cleaned up the saving of the dataframe to CSV and some general clean up.