Map <C-Enter> for vim and make it always submit for submit_on_enter - #226
Merged
Merged
Conversation
|
👀 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After using #222 for a bit, I noticed that it would be nice to still have submit on
<C-Enter>.I haven't added
<S-Enter>because that behaves weirdly in vim in normal mode and I didn't want to go digging what it does exactly.Do we want
<C-Enter>to have a separate toggle insubmit_on_enteror do the opposite of<Enter>? A lot of chat clients have one of the two as newline and the other as send and have a setting to toggle which is which.