Raise clear error when gridsearch() receives multiple TimeSeries - #3191
Merged
dennisbader merged 5 commits intoSep 18, 2026
Merged
dennisbader merged 5 commits into
dennisbader merged 5 commits into
Conversation
`gridsearch()` only supports a single TimeSeries for `series`, `val_series`, `past_covariates`, and `future_covariates`. Passing a sequence of TimeSeries previously failed deep in the call stack with a cryptic error (e.g. "The two TimeSeries sequences must have the same length"), making the actual problem hard to diagnose. Fixes unit8co#1622
dennisbader
approved these changes
Sep 18, 2026
dennisbader
left a comment
dennisbader
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot for this PR and your first contribution @COMPUMAX-EC 🚀
Everything looks good. I applied some minor changes to make it ready for merging.
I'll merge once all tests have passed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3191 +/- ##
=======================================
Coverage 97.06% 97.06%
=======================================
Files 169 169
Lines 18898 18901 +3
=======================================
+ Hits 18343 18346 +3
Misses 555 555 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1622
gridsearch()only supports a singleTimeSeriesforseries,val_series,past_covariates, andfuture_covariates. Passing a sequence ofTimeSeriespreviously failed deep in the call stack with a cryptic error (e.g."The two TimeSeries sequences must have the same length"), instead of a clear message at the point of the mistake.This adds an early validation check using the existing
get_series_seq_typehelper, raising aValueErrorthat names the offending argument, plus a parametrized test covering all four arguments.