Skip to content

logx: use unknwon.dev/x/logx and prop drill logger into handlers - #30

Merged
unknwon merged 1 commit into
mainfrom
logx-prop-drill
Nov 13, 2026
Merged

unknwon merged 1 commit into
mainfrom
logx-prop-drill

Conversation

@unknwon

@unknwon unknwon commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Aligns logging with pgrok.

  • Replace internal/logx with the shared unknwon.dev/x/logx module (same API).
  • Remove f.Map(logger). Handler constructors (authorize, serveBatch, serveUpload, serveDownload, serveVerify, serveHealthz) take logger *logx.Logger as their first argument, scoped at the call site in main.go.
  • Set the charmlog time format to time.DateTime.

The health check logger now has a [healthz] scope, which it did not have before.

Test plan

  • go build ./..., go vet ./..., golangci-lint run (0 issues), go test ./....
  • Ran lfsd with a minimal config and checked startup log output and scoping.

Replace the internal logx package with the shared unknwon.dev/x/logx module,
matching pgrok. Handler constructors now take the logger as their first
argument, scoped at the call site, instead of resolving it from flamego's
injector. Also set the charmlog time format to time.DateTime.
@unknwon
unknwon merged commit 9d9c00e into main Nov 13, 2026
5 checks passed
@unknwon
unknwon deleted the logx-prop-drill branch November 13, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant