Repository navigation
logx: use unknwon.dev/x/logx and prop drill logger into handlers - #30
Merged
Merged
Conversation
Replace the internal logx package with the shared unknwon.dev/x/logx module, matching pgrok. Handler constructors now take the logger as their first argument, scoped at the call site, instead of resolving it from flamego's injector. Also set the charmlog time format to time.DateTime.
unknwon
force-pushed
the
logx-prop-drill
branch
from
November 13, 2026 04:06
2018fdf to
08e71d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns logging with pgrok.
internal/logxwith the sharedunknwon.dev/x/logxmodule (same API).f.Map(logger). Handler constructors (authorize,serveBatch,serveUpload,serveDownload,serveVerify,serveHealthz) takelogger *logx.Loggeras their first argument, scoped at the call site inmain.go.time.DateTime.The health check logger now has a
[healthz]scope, which it did not have before.Test plan
go build ./...,go vet ./...,golangci-lint run(0 issues),go test ./....lfsdwith a minimal config and checked startup log output and scoping.