docs(react): document <Button> component props (#25)#50
Open
NitinSingh07 wants to merge 1 commit into
Open
Conversation
|
Thanks for picking this up! Team is reviewing the PR, will get back to you shortly! |
Author
|
Sure, I look forward to the team's review summary and suggested changes if there's any. |
Collaborator
|
Thanks for expanding the Button documentation. I tested the documented behavior against the latest Elements build in Chrome and found a few details to correct:
The documented Arial and |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 31 31
Lines 1937 1937
Branches 382 382
=======================================
Hits 1850 1850
Misses 86 86
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25
Adds comprehensive documentation and prop references for the
<Button>component in@unlayer/react-elements.Key Changes
children,text,href,backgroundColor,color,fontSize,fontWeight,fontFamily,padding,borderRadius,width, andtextAlign, including exact default values.fontFamily({ label, value }),fontWeight(numeric value),href(string URL vs link object), andwidth="100%"for full-width layout.buttonColors,border, and thevaluesescape hatch for advanced customization.Location
packages/react/README.mdunderComponent Reference -> Button.Verification
pnpm build: Completed successfully.pnpm test: All tests passed.