feat: add support for processing instructions - #145
Delta-official wants to merge 2 commits into
Conversation
|
i think there have been some changes to html5lib-tests where these tests are now maintained in another repo. you'd have to search the issue tracker for it. if so, i would really like to switch to that repo |
|
From the looks of it, the tokenizer tests never ended up getting moved to wpt, so I'm unsure what to do |
|
i've caught up with the changes in html5lib-tests and it seems that tokenizer tests are still "supposed to be" maintained. so i think the right course of action is to file a PR upstream, then update the git submodule here to use these new tests. this will then break the tree builder tests in html5gum. i'm fine with either having a separate html5lib-tests checkout for those, or if you want to take on the wpt migration that would be greatly apprechiated too (i haven't checked how much work that would be) |
|
Tree builder tests should be compatible with the ones in |
|
Funnily enough, I'm blocked by |
Adds support for processing instructions (
<?target data?>). This probably needs a major bump as theEmittertrait got new methods on it and the enums for events got a new variant.Sadly the
html5lib-teststests don't pass (at least not yet) because they rely on the old behaviour of interpreting every tag starting with a<?as a bogus comment. Not really sure what to do about this; I might try upstreaming the required changes.Closes #144