Add Plugin.plugin, PinnedVersion.plugin and Runtime.plugin resources - #169
Merged
Merged
Conversation
Signed-off-by: Jonasz Łasut-Balcerzak <jonasz@upbound.io>
Move Plugin from the root vault group into plugin.vault.upbound.io next to PinnedVersion and Runtime. Upjet derives the group from the words after the provider prefix, so the single-word vault_plugin fell back to the root group; a ShortGroup configurator fixes that. vault_plugin_runtime is a Terraform Plugin Framework resource in the fork, so register it in the framework external-name map; listed in the SDK map, the provider panicked at startup. Give it a templated "<type>/<name>" ID: the framework Observe always reads with the ID from GetIDFn, and the resource rejects the empty one produced by IdentifierFromProvider. Replace the examples with self-contained, uptestable ones for both scopes: a community vault-plugin-auth-jwt registration, a pinned version bundling its own plugin, and a container runtime. Vault only accepts a plugin whose command exists in plugin_directory, so the e2e Helm values add that directory with an init container that downloads the plugin binary. setup.sh passes the values file and matches only the STATUS line when checking for an existing release. Signed-off-by: Jonasz Łasut-Balcerzak <jonasz@upbound.io>
Contributor
Author
|
/test-examples="examples/cluster/plugin/plugin.yaml" |
Contributor
Author
|
/test-examples="examples/cluster/plugin/runtime.yaml" |
Contributor
Author
|
/test-examples="examples/cluster/plugin/pinnedversion.yaml" |
jonasz-lasut
marked this pull request as ready for review
September 10, 2026 09:10
jonasz-lasut
requested review from
erhancagirici,
sergenyalcin,
turkenf and
ulucinar
as code owners
September 10, 2026 09:10
sergenyalcin
approved these changes
Sep 15, 2026
sergenyalcin
left a comment
sergenyalcin
left a comment
Member
There was a problem hiding this comment.
Thanks @jonasz-lasut LGTM!
Member
There was a problem hiding this comment.
We may consider adding a license statement.
Contributor
Author
There was a problem hiding this comment.
I'll merge after CI passes, added license
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Updates setup.sh to use custom values.yaml for helm deployment to support e2e tests for PinnedVersion
Fixes #94
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
/test-examples="examples/cluster/plugin/plugin.yaml"
/test-examples="examples/cluster/plugin/runtime.yaml"
/test-examples="examples/cluster/plugin/pinnedversion.yaml"