You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
gamescope: clear the boot splash for games that draw through X - #2224
Under gamescope, OpenGL-only games such as Balatro kept the "Launching game..." splash up forever while the game ran behind it. The daemon clears the splash only when it gets a game-window note. Only the guest ICD shim sends that note, and only from its Vulkan swapchain present. A game whose frames reach X as plain drawing (zink output, GDI) never presents through the shim, so the note never came.
This PR moves the gamescope payload to 20261023. The new payload carries GameNative/gamescope#4 (patch A43). With A43, gamescope sends the same note when the wine desktop window keeps getting frames on its own surface (20 or more per second) and has a game child window. Games that present through the shim (DXVK, VKD3D) are not affected, because their frames go to the override surface. The payload differs from 20261022.13 only in bin/gamescope. The daemon library does not change. The archive is already on both CDN URLs (sha256 972d44b4f7b4f63e92f8ef0c1255250bf3ac33b87c2ca72d37c8185c434e832a).
I tested it on a POCO F6 (Adreno 735, Turnip, Proton 11.0-2-arm64ec-7, legacy build) with the new bin/gamescope:
Balatro (2379780): gamescope sent the note about 9 s after the launch, the splash cleared and the main menu showed.
Blazing Chrome (609110, DXVK): gamescope sent no note. The shim cleared the splash at the first present as before, and the game ran.
Recording
No recording attached.
Type of Change
Bug fix
Performance / stability improvement
Compatibility improvements
Other (requires prior approval)
Checklist
If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
I have attached a recording of the change.
I have read and agree to the contribution guidelines in CONTRIBUTING.md.
Summary by cubic
Fixes the "Launching game..." splash staying on screen for games that draw frames through X, so OpenGL-only games like Balatro no longer run behind a permanent splash.
Bumps the gamescope payload to 20261023, which now clears the splash when a wine desktop window with a game child window receives frames on its own surface (20+ per second). Games that present through the shim (DXVK, VKD3D) are unaffected because their frames still go through the override surface.
Written for commit 29e4023. Summary will update on new commits.
Summary by CodeRabbit
Updates
Updated the Gamescope support package to version 20261023. The app now checks for and uses the package matching this version.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
The Gamescope payload version changes from 20261022.13 to 20261023. The version-dependent archive name and readiness check use the updated value.
Changes: Gamescope payload version
Layer / File(s)
Summary
Update payload version app/src/main/java/app/gamenative/display/GamescopePayload.kt
GamescopePayload.VERSION changes to 20261023. The version-dependent archive name and readiness check use this value.
The payload update is internally consistent and presents no concrete merge-blocking risk.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly describes the primary objective: clearing the gamescope boot splash for games that draw through X.
Description check
The description follows the required structure and clearly explains the problem, implementation, payload change, checksum, compatibility impact, and test results. No recording is attached, but the rem…
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description follows the required structure and clearly explains the problem, implementation, payload change, checksum, compatibility impact, and test results. No recording is attached, but the remaining required sections are complete.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Under gamescope, OpenGL-only games such as Balatro kept the "Launching game..." splash up forever while the game ran behind it. The daemon clears the splash only when it gets a game-window note. Only the guest ICD shim sends that note, and only from its Vulkan swapchain present. A game whose frames reach X as plain drawing (zink output, GDI) never presents through the shim, so the note never came.
This PR moves the gamescope payload to 20261023. The new payload carries GameNative/gamescope#4 (patch A43). With A43, gamescope sends the same note when the wine desktop window keeps getting frames on its own surface (20 or more per second) and has a game child window. Games that present through the shim (DXVK, VKD3D) are not affected, because their frames go to the override surface. The payload differs from 20261022.13 only in bin/gamescope. The daemon library does not change. The archive is already on both CDN URLs (sha256 972d44b4f7b4f63e92f8ef0c1255250bf3ac33b87c2ca72d37c8185c434e832a).
I tested it on a POCO F6 (Adreno 735, Turnip, Proton 11.0-2-arm64ec-7, legacy build) with the new bin/gamescope:
Recording
No recording attached.
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Fixes the "Launching game..." splash staying on screen for games that draw frames through X, so OpenGL-only games like Balatro no longer run behind a permanent splash.
Bumps the gamescope payload to
20261023, which now clears the splash when a wine desktop window with a game child window receives frames on its own surface (20+ per second). Games that present through the shim (DXVK, VKD3D) are unaffected because their frames still go through the override surface.Written for commit 29e4023. Summary will update on new commits.
Summary by CodeRabbit