Skip to content

Host FEX 2611-gn-6 in the component manifest - #2357

Merged
utkarshdalal merged 1 commit into
masterfrom
host-fex-2611-gn-6
Nov 10, 2026
Merged

utkarshdalal merged 1 commit into
masterfrom
host-fex-2611-gn-6

Conversation

@utkarshdalal

@utkarshdalal utkarshdalal commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Description

Adds FEXCore 2611-gn-6 to manifest.json so it shows up in the FEX version list for download. It is the GameNative series rebased onto upstream FEX-2611 with the offline code cache fixes and the shipped FEXOfflineCompiler32/64.exe (GameNative/FEX PR 9, release tag gn-6). The pack is already on the CDN at downloads.gamenative.app/FEXCore-2611-gn-6.wcp (sha256 7455d152192f08927871d459f2dc654a9d40f9690205aac6fb6f08c753bfa2db, 1,838,412 bytes).

The default (DefaultVersion.FEXCORE) stays 2610-gn-5 until gn-6 has been through device testing; 2610-gn floors in the config overlays keep resolving within the 2610-gn line, so nothing moves automatically.

Recording

Manifest-only change, no UI.

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Adds FEXCore 2611-gn-6 to manifest.json so it appears in the FEX version list for download.

  • New entry points to the already-hosted pack on the CDN; no content changes.
  • Default version stays at 2610-gn-5 until 2611-gn-6 passes device testing, so no users move automatically.

Written for commit 6c957d9. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • New Features
    • Added FEX 2611-gn (6) to the catalog, with a download link.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The fexcore catalog adds FEX 2611-gn (6), with its ID, display name, download URL, and bionic variant.

Changes: FEX Catalog Entry

Layer / File(s) Summary
Add FEX catalog entry
manifest.json
Adds the FEX 2611-gn (6) entry, including its ID, display name, download URL, and bionic variant.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Possibly related PRs

Merge Risk: Minimal · up to 6c957

The FEX catalog addition has no identified merge-blocking issue and is mergeable subject to normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the FEXCore version added to the component manifest.
Description check Passed The description covers the change, its purpose, type, and checklist. It explains why no recording is attached.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4ffe3a6e-eb04-4d80-823f-afd98bc2ed54
Commits

Reviewing files that changed from the base of the PR and between 8f375e7 and 6c957d9.

Files selected for processing: 1

  • manifest.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="manifest.json">

<violation number="1" location="manifest.json:943">
P3: This adds a manifest entry but leaves `updatedAt` at `2026-11-04`; update the date so the manifest metadata reflects this change.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread manifest.json
"variant": "bionic"
},
{
"id": "2611-gn-6",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: This adds a manifest entry but leaves updatedAt at 2026-11-04; update the date so the manifest metadata reflects this change.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At manifest.json, line 943:

<comment>This adds a manifest entry but leaves `updatedAt` at `2026-11-04`; update the date so the manifest metadata reflects this change.</comment>

<file context>
@@ -938,6 +938,12 @@
         "variant": "bionic"
+      },
+      {
+        "id": "2611-gn-6",
+        "name": "FEX 2611-gn (6)",
+        "url": "https://downloads.gamenative.app/FEXCore-2611-gn-6.wcp",
</file context>

@utkarshdalal
utkarshdalal merged commit 798ce68 into master Nov 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant