Repository navigation
Themes: New theme button, several named themes, and an Upload that is easy to find - #2478
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
added 3 commits
November 20, 2026 09:57
…e and delete, Share shown by name and on the Community tab
… them, without the original theme's files
… and your own themes come first in the share list
added 2 commits
November 20, 2026 10:30
…he Community list reloads after a share
… a second line on narrow screens
added 2 commits
November 20, 2026 11:08
…uttons carry the focus ring, focus follows a new or deleted row
…se in the upload terms is one press away
utkarshdalal
marked this pull request as ready for review
November 20, 2026 06:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Making and sharing a theme was hard to find: the only way was a fixed row named "Custom" on the Installed tab, and sharing was an unlabeled icon.
Making a theme
Uploading (was "Share")
New strings are translated for all 15 languages.
Narrow screens
Controller
Notes
themes/state.jsonwithcustomandname. An older build does not know these entries and drops them at its next save.Tested on a Retroid Pocket 6 (debug build):
theme.jsonandtheme.csswith--gn-*variables).Known and not changed here: in the rename dialog the text cursor starts before the first letter; with many themes installed a change takes a few seconds to show.
Recording
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.