Skip to content

Themes: New theme button, several named themes, and an Upload that is easy to find - #2478

Merged
utkarshdalal merged 8 commits into
masterfrom
themes-community-empty-share-hint
Nov 20, 2026
Merged

utkarshdalal merged 8 commits into
masterfrom
themes-community-empty-share-hint

Conversation

@utkarshdalal

@utkarshdalal utkarshdalal commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Description

Making and sharing a theme was hard to find: the only way was a fixed row named "Custom" on the Installed tab, and sharing was an unlabeled icon.

Making a theme

  • The Installed tab has a New theme button. It asks for a name, adds the theme turned on at the top of the list and opens its options.
  • A user can have several themes of their own. Each can be renamed (pencil button) and deleted.
  • Themes made in the app are always listed first, above the installed ones, and apply over them. The move arrows work inside each group.
  • The fixed "Custom" row is gone for users who never changed it. A Custom theme that has saved options, is on, or was shared stays as an ordinary theme.

Uploading (was "Share")

  • The action is now called Upload in every language: "Share" read as sending a theme to a friend.
  • Themes made in the app show an Upload button with its label. Other themes keep the icon.
  • The Community tab has an Upload a theme button that lists the installed themes that can be shared, the user's own first. With none, it points to New theme.
  • SteamOS-like themes can be uploaded. The upload is the look the app made of the theme (colors, gradients, layout values); images and fonts of the original theme are left out, only files the user picked in its options are included. The description is prefilled with "Based on by ". The wording of the rights checkbox is not changed.
  • A preview larger than the list accepts is left out of the upload instead of failing it.
  • The Community list reloads after a share.

New strings are translated for all 15 languages.

Narrow screens

  • Under 600 dp wide, a theme row puts its buttons on a second line, so the theme name is no longer cut down to a few letters.

Controller

  • A multi-line text field (the upload Description) no longer holds the D-pad: up and down move focus until A starts editing; B ends editing. This is in the shared text field, so other multi-line fields get it too.
  • Buttons in the Themes dialogs use the app's ring buttons, so focus shows the rotating ring.
  • "Read the upload terms" is reachable from the dialog buttons; in the terms viewer, Close is one press to the right of the text.
  • After New theme, focus lands on the new row's Options button; after a delete, on the row that takes its place.
  • On the Community tab, up from "Upload a theme" goes to the search field, left stays, and right from the last filter chip stays.

Notes

  • State: themes made with New theme are saved in themes/state.json with custom and name. An older build does not know these entries and drops them at its next save.

Tested on a Retroid Pocket 6 (debug build):

  • Touch, landscape and portrait: New theme, edit options, rename, app restart (theme kept and still applied), a second theme, delete, own themes listed first.
  • Upload to the production list and removal from it: an own theme with a gradient, and a SteamOS-like theme (the stored zip held only theme.json and theme.css with --gn-* variables).
  • Controller only (real pad input): New theme, name dialog, the row and its options, rename, every control of the upload dialog, the terms viewer, the Community tab and its list, delete, and where focus lands after each dialog.

Known and not changed here: in the rename dialog the text cursor starts before the first letter; with many themes installed a change takes a few seconds to show.

Recording

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Utkarsh Dalal added 3 commits November 20, 2026 09:57
…e and delete, Share shown by name and on the Community tab
… and your own themes come first in the share list
@utkarshdalal utkarshdalal changed the title Themes: the empty Community tab says how to share a theme Themes: New theme button, several named themes, and Share that is easy to find Nov 20, 2026
Utkarsh Dalal added 2 commits November 20, 2026 10:30
@utkarshdalal utkarshdalal changed the title Themes: New theme button, several named themes, and Share that is easy to find Themes: New theme button, several named themes, and an Upload that is easy to find Nov 20, 2026
Utkarsh Dalal added 2 commits November 20, 2026 11:08
…uttons carry the focus ring, focus follows a new or deleted row
@utkarshdalal
utkarshdalal marked this pull request as ready for review November 20, 2026 06:40
@utkarshdalal
utkarshdalal merged commit c9aa55f into master Nov 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant