Repository navigation
Optimize: ask the server about a session and report a step's outcome from three minutes of play - #2480
Merged
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
utkarshdalal
force-pushed
the
optimize-verdict-frame-budget
branch
from
November 20, 2026 10:10
1713a5d to
73dedda
Compare
…from three minutes of play The exit dry-run for an unsure or unlisted verdict, the throttled-session ask, a step's outcome report and the baseline a step is judged against now start three minutes after the session's first frame (ASK_PLAY_SEC; ASK_GAMEPLAY_SEC in gameplay_s), so the server sees short sessions and decides on them. The app's own verdict is unchanged.
utkarshdalal
force-pushed
the
optimize-verdict-frame-budget
branch
from
November 20, 2026 10:15
73dedda to
54e4ee1
Compare
utkarshdalal
marked this pull request as ready for review
November 20, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The app only asked the server about a session, and only reported a step's outcome, once the session had run for several minutes, so a short session never reached the server at all.
This moves that point to three minutes after the session's first frame (
OptimizeServer.ASK_PLAY_SEC;ASK_GAMEPLAY_SECis the same point in the session'sgameplay_s, which counts fromSessionVerdict.WARMUP_SECafter the first frame). From there:OptimizeServer.asksAtExit), with the session's per-second samples as before;OptimizeServer.throttledSession);OptimizeJudge.COMPARABLE_GAMEPLAY_SEC, used by the judge,OptimizeLadders.acceptedand the baseline lookup).The server's answer decides the card and the judgement, as it already does when it answers.
SessionVerdictand its tests are untouched: the app's own verdict is unchanged and still only used when there is no answer. No new user-visible strings.With an older server the app asks earlier and gets that server's answer for a short session (no card), and a step's session from three minutes on is judged by the app's own judge, with the server's answer recorded beside it.
Recording
None: no visible UI change.
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Testing
OptimizeServerTest,OptimizeJudgeTest,OptimizeCrashRevertTestandOptimizeOfferTestcover the new ask point (one second before it does not ask or judge, at it does).