Skip to content

Add Proton 11.0-2 rebuild 13 to the manifest - #2483

Merged
utkarshdalal merged 1 commit into
masterfrom
proton-11.0-2-build-13
Nov 20, 2026
Merged

utkarshdalal merged 1 commit into
masterfrom
proton-11.0-2-build-13

Conversation

@utkarshdalal

@utkarshdalal utkarshdalal commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Description

Adds Proton 11.0-2 rebuild 13 to the manifest. It is not the default: new containers stay on rebuild 12, and existing containers keep the version they have.

Proton 11.0-2 rebuild 13 is GameNative/proton-wine proton_11.0-2 at 63a44331f (release proton-11.0-2-20261120): rebuild 12 plus GameNative/proton-wine#142, which removes a server round trip from each create and close of an unnamed semaphore. Measured on one Unity game on one Snapdragon 8 Elite handheld: about 30 fps before, about 41-45 fps with it. The change applies to both the arm64ec and the x86_64 builds.

Files:

  • manifest.json: proton-11.0-2-x86_64-13, proton-11.0-2-arm64ec-13.
  • BionicSteamAssetsDependency: the rebuild 13 ids get the Proton 11 steam.exe and lsteamclient handling.

Hosted files (profile.json versionName 11.0-2-arm64ec / 11.0-2-x86_64, versionCode 13):

  • proton-11.0-2-arm64ec-13.wcp: 100,059,303 bytes, sha256 2c53d73c0e2f762d39a1421e62c0ba1b4beda8c60b4af5253512edb7525918ad
  • proton-11.0-2-x86_64-13.wcp: 64,722,993 bytes, sha256 6e8064d9eb91e1bf4296894de544b8658aaedcb8e99586c84e4d8d12035d68d8

Recording

None.

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Adds Proton 11.0-2 rebuild 13 to the manifest. It is not the default: new containers stay on rebuild 12, and existing containers keep the version they have.

Written for commit 236673a. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • New Features
    • Added support for Proton 11.0-2 revision 13 for x86-64 and ARM64ec, including their bundled Steam client components. These builds are now available in the package list.

Rebuild 13 is GameNative/proton-wine proton_11.0-2 at 63a44331f (release
proton-11.0-2-20261120): rebuild 12 plus GameNative/proton-wine#142, where
creating and closing a private unnamed semaphore no longer takes a server
round trip each time. The wcp profile.json reads versionName
11.0-2-arm64ec / 11.0-2-x86_64 with versionCode 13.

The default for new containers stays on rebuild 12. The rebuild 13 ids join
BionicSteamAssetsDependency so those installs get the Proton 11 steam.exe
and lsteamclient handling.
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The manifest adds Proton 11.0-2 revision 13 packages for x86-64 and ARM64ec. Launch dependency mappings recognize both builds as bundling lsteamclient and select STEAM_EXE_PROTON11.

Changes: Proton 11.0-2 revision 13 support

Layer / File(s) Summary
Add revision 13 packages and launch mappings
manifest.json, app/src/main/java/app/gamenative/utils/launchdependencies/BionicSteamAssetsDependency.kt
The manifest adds x86-64 and ARM64ec revision 13 package entries. The launch dependency mappings include both builds in BUNDLED_LSTEAMCLIENT_WINE and map them to STEAM_EXE_PROTON11.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Possibly related PRs

Suggested reviewers: joshuatam

Merge Risk: Minimal · up to 23667

This adds an opt-in Proton 11.0-2 rebuild 13 for both architectures and maps it to the existing Proton 11 steam.exe and lsteamclient handling. It follows the same pattern as the earlier rebuilds, and the default version is unchanged. Merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: adding Proton 11.0-2 rebuild 13 to the manifest. The changeset adds two manifest entries (x86_64 and arm64ec, revision 13) and wires them into BionicSteamAssetsDepende…
Description check Passed The description follows the repository template. It explains what changed and why, states that rebuild 13 is not the default, and gives hosted file sizes and SHA-256 hashes. It checks the Performance …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: adding Proton 11.0-2 rebuild 13 to the manifest. The changeset adds two manifest entries (x86_64 and arm64ec, revision 13) and wires them into BionicSteamAssetsDependency. The title does not mention the dependency wiring, but that is supporting detail, so the title is related to the main change.

Full details: Description check

Explanation

The description follows the repository template. It explains what changed and why, states that rebuild 13 is not the default, and gives hosted file sizes and SHA-256 hashes. It checks the Performance / stability improvement type and marks several checklist items. The Recording section says 'None' and the recording checkbox is unchecked, so the template's recording requirement is not met. The Compatibility and Other options are left unchecked, which is acceptable.

Resolution

Optional: attach a recording or GIF, or explain more clearly why no recording applies. The Recording section currently says 'None' while the template asks for a short recording or GIF of the change. The author should confirm that the approval checklist item is accurate.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 34c943e2-9899-4e44-a10b-7e08ff513136
Commits

Reviewing files that changed from the base of the PR and between 82a17f9 and 236673a.

Files selected for processing: 2

  • app/src/main/java/app/gamenative/utils/launchdependencies/BionicSteamAssetsDependency.kt
  • manifest.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@utkarshdalal
utkarshdalal merged commit 973d31f into master Nov 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant