Skip to content

PR-4: Dead code & hygiene — remove online_providers, playwright artifact, Cursor rules; ignore output/ - #25

Merged
utkuvibing merged 3 commits into
mainfrom
chore/pr4-dead-code-hygiene
Aug 30, 2026
Merged

PR-4: Dead code & hygiene — remove online_providers, playwright artifact, Cursor rules; ignore output/#25
utkuvibing merged 3 commits into
mainfrom
chore/pr4-dead-code-hygiene

Conversation

@utkuvibing

Copy link
Copy Markdown
Owner

PR-4 — Dead code & hygiene (Phase 0)

Roadmap WP-4: delete core/online_providers/ (zero importers), tracked output/playwright/*.png, .gitignore += output/ (deferred from PR-3), obsolete Cursor rules, and the stale-branch evidence table for owner sign-off.

No branch, worktree, or remote-tracking ref is deleted in this PR. Branch cleanup is owner-gated and happens after merge, as a separate follow-up.

Commits (one per hygiene concern)

  1. chore: remove obsolete Cursor agent rules (workflow retired).cursor/rules/ (3 files, 38 lines). Cursor is no longer part of the workflow.
  2. chore: remove dead core/online_providers package (zero importers) + ruff ratchet entries — 6 files / ~840 LOC; also removes the three F401 per-file ignores from ruff.toml per the ratchet contract ("burn down frozen debt … then delete its entry").
  3. chore: drop tracked playwright artifact, ignore output/ (PR-3 deferral) — removes the one tracked file under output/, then adds output/ to .gitignore.

Why core/online_providers/ is safe to delete

  • Zero external importers: every online_providers reference in tracked *.py was intra-package (verified by grep across backend/, dash_app/, core/, ui/, tools/, tests/; no dynamic/string-based coupling either).
  • No dependency entanglement: the package imported only httpx (kept — it is the Dash↔FastAPI seam) + stdlib. pymatgen/mp-api stay in requirements.txt (used by ingest tooling / XRD matching).
  • No test references → suite counts unchanged (confirmed below).
  • The three frozen F401 entries for its files are deleted from ruff.toml in the same commit, per the PR-2 ratchet contract.

Verification (local, Python 3.11.15 fresh venv, pip install -e ".[dev]")

  • ruff check .All checks passed
  • pytest tests/ -q1171 passed, 15 skipped (identical to the PR-3 baseline; zero new failures)
  • git grep online_providers → no matches in tracked files
  • git ls-files output/ → empty
  • Diff vs main: 12 files changed, +3 / −879

Stale-branch evidence table (owner sign-off required — informational only)

Verified 2026-08-30 via git ls-remote --heads origin: GitHub has exactly three heads (main, chore/pr3-packaging-truth, codex/rag-lab-docs). Everything else under origin/… is a stale local remote-tracking ref.

C1. Stale local remote-tracking refs → cleanup = git fetch --prune (local-only, no remote deletion)

Ref Points at Evidence
origin/chore/pr2-real-ci 468cc94 PR #23 squash-merged; diff vs main is only reverse-PR-3 noise (old tip predates PR-3) → prune
origin/graph-compare 966c0c6 GitHub branch deleted; local branch decision in C4 → prune

C2. Local branches / worktrees — fully absorbed (0 content diff vs main) — local cleanup candidates on sign-off

Branch Where Evidence
chore/pr3-packaging-truth (local twin) local @ 9f4b0f1 PR #24 squash-merged; git diff main = empty
main-2 local worktree (orca/workspaces) @ 50b16c4 0 diff vs main
main-3 local worktree (orca/workspaces) @ 50b16c4 same commit as main (verify 0-diff before deleting)

C3. Live remote GitHub branch — absorbed — remote-deletion candidate on sign-off

Branch Evidence
origin/chore/pr3-packaging-truth @ 9f4b0f1 PR #24 squash-merged; only live remote deletion candidate

C4. Local branches with unique unmerged work — owner must choose merge / park / delete

⚠️ These are local-only; no remote backup exists, so deletion is irreversible.

Branch Where Unique commits Content
graph-compare local @ 5909070 (ahead 2 of the already-deleted origin tip) 3 academic compare mode + stacked-plot polish + publication axis styling (~106 files, +8.1k vs main)
codex/literature-ftir-20260403 local worktree (.codex/worktrees/42b4) @ 3665b73 1 FTIR literature compare in spectral results flow
electron-rebuild-parity local @ d606d63 14 Electron parity slices 1–8 (XRD input review, preset manager, compare workflow)
t3code/ai-research-citation-mvp local @ cff722b 1 XRD family-consistent screening support

Explicitly preserved (do not touch)

  • codex/rag-lab-docs (local + origin @ 1aee3b8) — standing decision: RAG merges only by separate approval.
  • stash@{0} codex-temp-before-cleanup-push — PR-1 note: two latent test fixes (license date-bomb, XRD .xy import path).

Out of scope (stays for later WPs)

  • Any branch/worktree/remote deletion (owner-gated follow-up; worktrees must be removed before their branches).
  • Tracking docs/roadmap.md + docs/scout-report.md (separate docs PR; the PR-4 roadmap status flip lands there).
  • PR-5 security trio is next per roadmap.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
materialscope 445af1b Aug 30 2026, 06:06 PM

@utkuvibing
utkuvibing merged commit 166a083 into main Aug 30, 2026
3 of 4 checks passed
@utkuvibing
utkuvibing deleted the chore/pr4-dead-code-hygiene branch August 30, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant