PR-4: Dead code & hygiene — remove online_providers, playwright artifact, Cursor rules; ignore output/ - #25
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
materialscope | 445af1b | Aug 30 2026, 06:06 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-4 — Dead code & hygiene (Phase 0)
Roadmap WP-4: delete
core/online_providers/(zero importers), trackedoutput/playwright/*.png,.gitignore += output/(deferred from PR-3), obsolete Cursor rules, and the stale-branch evidence table for owner sign-off.No branch, worktree, or remote-tracking ref is deleted in this PR. Branch cleanup is owner-gated and happens after merge, as a separate follow-up.
Commits (one per hygiene concern)
chore: remove obsolete Cursor agent rules (workflow retired)—.cursor/rules/(3 files, 38 lines). Cursor is no longer part of the workflow.chore: remove dead core/online_providers package (zero importers) + ruff ratchet entries— 6 files / ~840 LOC; also removes the threeF401per-file ignores fromruff.tomlper the ratchet contract ("burn down frozen debt … then delete its entry").chore: drop tracked playwright artifact, ignore output/ (PR-3 deferral)— removes the one tracked file underoutput/, then addsoutput/to.gitignore.Why
core/online_providers/is safe to deleteonline_providersreference in tracked*.pywas intra-package (verified by grep acrossbackend/,dash_app/,core/,ui/,tools/,tests/; no dynamic/string-based coupling either).httpx(kept — it is the Dash↔FastAPI seam) + stdlib.pymatgen/mp-apistay inrequirements.txt(used by ingest tooling / XRD matching).F401entries for its files are deleted fromruff.tomlin the same commit, per the PR-2 ratchet contract.Verification (local, Python 3.11.15 fresh venv,
pip install -e ".[dev]")ruff check .→ All checks passedpytest tests/ -q→ 1171 passed, 15 skipped (identical to the PR-3 baseline; zero new failures)git grep online_providers→ no matches in tracked filesgit ls-files output/→ emptyStale-branch evidence table (owner sign-off required — informational only)
Verified 2026-08-30 via
git ls-remote --heads origin: GitHub has exactly three heads (main,chore/pr3-packaging-truth,codex/rag-lab-docs). Everything else underorigin/…is a stale local remote-tracking ref.C1. Stale local remote-tracking refs → cleanup =
git fetch --prune(local-only, no remote deletion)origin/chore/pr2-real-ci468cc94origin/graph-compare966c0c6C2. Local branches / worktrees — fully absorbed (0 content diff vs main) — local cleanup candidates on sign-off
chore/pr3-packaging-truth(local twin)9f4b0f1git diff main= emptymain-2orca/workspaces) @50b16c4main-3orca/workspaces) @50b16c4C3. Live remote GitHub branch — absorbed — remote-deletion candidate on sign-off
origin/chore/pr3-packaging-truth@9f4b0f1C4. Local branches with unique unmerged work — owner must choose merge / park / delete
graph-compare5909070(ahead 2 of the already-deleted origin tip)codex/literature-ftir-20260403.codex/worktrees/42b4) @3665b73electron-rebuild-parityd606d63t3code/ai-research-citation-mvpcff722bExplicitly preserved (do not touch)
codex/rag-lab-docs(local + origin @1aee3b8) — standing decision: RAG merges only by separate approval.stash@{0}codex-temp-before-cleanup-push— PR-1 note: two latent test fixes (license date-bomb, XRD.xyimport path).Out of scope (stays for later WPs)
docs/roadmap.md+docs/scout-report.md(separate docs PR; the PR-4 roadmap status flip lands there).