fix(ci): version lock Rust and zigbuild - #298
Merged
Merged
Conversation
Aryex
force-pushed
the
fix/ci-arm64-zigbuild-unpinned
branch
3 times, most recently
from
August 24, 2026 22:25
08e2c68 to
79bfa8c
Compare
Aryex
changed the title
Aryex
force-pushed
the
fix/ci-arm64-zigbuild-unpinned
branch
2 times, most recently
from
August 24, 2026 23:13
90baac2 to
9c3befd
Compare
Aryex
changed the title
The linux-gnu native build broke on aarch64 after Rust 1.98.0 began passing -Wl,--fix-cortex-a53-843419 to the linker (rust-lang/rust#155453), which the pinned cargo-zigbuild 0.20.1 did not recognise. The real cause was an unpinned Rust (install-rust used toolchain: stable) drifting past a stale-but-pinned cross-compiler. Lock both sides: install Rust via dtolnay/rust-toolchain pinned to 1.98.0 in ci.yml and cd.yml, and install zig 0.13.0 plus cargo-zigbuild 0.23.1 (0.23.0+ filters the arg) through pip in the install-zigbuild action. The pip install pulls ziglang in as a dependency and cargo-zigbuild finds zig via python3 -m ziglang, so no zig binary needs to be on PATH. dtolnay's targets input adds the rustup target cargo-zigbuild needs, replacing the install-zigbuild rust-target input. Also add .github/actions/** to CI's pull_request path filter so changes to composite actions trigger the workflow. Signed-off-by: Alex Le <alex.le@improving.com>
Aryex
force-pushed
the
fix/ci-arm64-zigbuild-unpinned
branch
from
August 24, 2026 23:16
9c3befd to
d482d2c
Compare
Aryex
changed the title
Aryex
changed the title
Aryex
marked this pull request as ready for review
August 24, 2026 23:19
jamesx-improving
approved these changes
Aug 24, 2026
prateek-kumar-improving
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unpinned Rust hit 1.98.0, which emits
-Wl,--fix-cortex-a53-843419on aarch64. Our pinned cargo-zigbuild 0.20.1 rejects it, so the arm64 link fails. Fix: pin Rust and the zig toolchain.cargo build.Issue link
None. CI regression from Rust stable drift (rust-lang/rust#155453).
Changes
1.98.0viadtolnay/rust-toolchain(ci.yml + cd.yml).0.13.0+ cargo-zigbuild0.23.1via pip ininstall-zigbuild..github/actions/**to CI'spull_requestpaths so action changes trigger CI.Limitations
rust-toolchain.tomlwould cover them.Testing
Checklist
Before submitting the PR make sure the following are checked:
git commit -s) per the DCO.bundle exec rubocop) and pass.