Repository navigation
feat: install gallery-dl from the app - #141
Merged
Merged
Conversation
Users had to install gallery-dl themselves before the Gallery page worked, which many did not know how to do (#136). - On Windows and x86_64 Linux, Settings > Dependencies and the Gallery page can install and update gallery-dl from the latest official Codeberg release (the project moved there; GitHub releases no longer carry binaries). The binary is checked against SHA256SUMS, streamed with gallerydl-download-progress events, and stored in app_data/bin, where the existing lookup already finds it. - macOS (and other platforms without an official standalone build) shows a copyable `brew install gallery-dl` / pip command and a re-check button instead. - A system gallery-dl is still preferred when present. - New error codes GALLERYDL_INSTALL_UNSUPPORTED and GALLERYDL_SYSTEM_MANAGED; GalleryDlStatus gains can_install. - The Gallery page's "Open Dependencies" button now opens the Dependencies tab instead of General. - i18n for all 13 locales, changelog entries, error code docs. Closes #136 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #136.
The Gallery page needs gallery-dl, but Youwee only used a system install, so users had to install it themselves. The reporter didn't know how. This PR lets Youwee install gallery-dl itself where an official standalone build exists, and shows clear instructions where one doesn't.
Where the binaries come from: gallery-dl moved to Codeberg. GitHub releases after 1.31 no longer carry binaries. Codeberg's official releases have
gallery-dl.exe,gallery-dl_x86.exeandgallery-dl.bin(x86_64 Linux) withSHA256SUMS. There is no official macOS build, so macOS gets Homebrew instructions instead.Behavior
%with MB → verifying.brew install gallery-dl(orpip install -U gallery-dl) command with a Check again button.Changes
services/gallerydl.rs:SHA256SUMSparsing, update check.GalleryDlStatus.can_install.commands/dependencies.rs:download_gallerydlstreams the binary, emitsgallerydl-download-progress, verifies SHA-256, writes via a temp file and rename, and sets the exec bit on Unix. It installs toapp_data/bin, where the existing lookup already looks.check_gallerydl_update.GALLERYDL_INSTALL_UNSUPPORTEDandGALLERYDL_SYSTEM_MANAGED, documented indocs/backend-error-codes.md.DependenciesContext: gallery-dl download, progress and update state. On startup it runs a silent update check for the app-managed copy.GalleryDlInstallcomponent shared by Settings and the Gallery page. It reuses the shared progress helper.systemGallerydlNotFoundremoved. Changelog entries in EN, VI and ZH-CN.Test plan
tsc, bun tests (114) andcargo checkpass (pre-commit hook)cargo testpasses (232), including the new gallery-dl tests200withcontent-length(so%works), andgallery-dl_x86.exe's SHA-256 matchesSHA256SUMSbrew install gallery-dl, Check again detects it🤖 Generated with Claude Code