fix(apps): audit-3 surgical batch (#33) - #37
Merged
Merged
Conversation
- Paint: Clear hit-tested standalone; it was swallowed by the swatch find, so clicks never cleared and set currentColor=''. The palette now holds colors-only swatches. - Windows: re-open the N/NW/NE resize rim above the titlebar drag handle via an instance hit-test predicate that survives engine applyGeom; maximized/dialog keep the full handle for restore-drag. - Shell: one-shot work-area re-clamp of just-restored windows on gesture end - the engine drops the restored box under the cursor unclamped; WEB-0038's clampWindowsToWorkArea untouched. - Files: inner list viewport binds to the window client height with a 120px floor instead of a fixed 150px strip. - Browser: address bar selects its text on focus so typing replaces.
Audit review follow-up (LOW 1 + LOW 2, notes PX-0185..0193), rebased onto origin/main b326ef9 (WEB-0038 #34): - Keyboard/taskbar restores no longer leave an armed pendingRestoreClamp that would fire at an arbitrary later pointerup anywhere. A document- level gesture flag arms deferral only while a pointer is actually down; restores arriving outside a gesture re-clamp immediately. The flag resets before reclamp's empty-pending early-return so it cannot wedge true. - A window closed mid-gesture is dropped from both trackers on the wm close event, so the next pointerup can never setGeometry a destroyed instance. - Rebase kept both window-manager handlers (WEB-0038's gated shrink clamp and this branch's chrome/arming handler are independent) and restored the clampPosition import the auto-merge silently dropped. Covered by three smoke tests: pointer restore still waits for gesture end (via pointercancel), keyboard restore consumes its clamp at arm time, and a mid-gesture close produces zero geometry writes on the dead instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
Audit-3 surgical fixes (audit WEB-0036):
Gates: 183 pass / 0 fail · tsc · oxlint · oxfmt repo-wide · build. Review: APPROVE (2 LOW findings fixed in 794fcf8).