Repository navigation
feat(spec): add quac:searchable for QGIS's Not searchable field flag - #20
Merged
Merged
Conversation
- A field whose configurationFlags hold NotSearchable gets `quac:searchable: false` on its table:columns entry, and readCollectionFieldEditRules reads it back as `notSearchable`. - The one reader of configurationFlags now serves this and the WMS and WFS flags; spec entry, schema, first-tier example and server snapshot added. - npm test, npm run typecheck and npm run test:server pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Sets the package and lockfile version for a pre-release from this branch, so a dependent application can try quac:searchable before the release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The schema's $id, QUAC_SCHEMA_URL in the JavaScript and the Python, the spec, the README, the examples and the test catalogues now name https://vectoriahq.github.io/quac/v0.2.0/schema.json; the v0.1.0 schema stays published at its own address. - Readers compare only the major version, so a catalogue listing v0.1.0 is still read. - npm test, npm run typecheck and npm run test:server pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
A new field on a
table:columnsentry,quac:searchable. It is written only asfalse, when the QGIS field'sconfigurationFlagsholdNotSearchable. That flag is Not searchable in the Configuration column of the Fields tab. QGIS's search of the active layer's features skips such a field (QgsActiveLayerFeaturesLocatorFilter,src/app/locator/qgsactivelayerfeatureslocatorfilter.cpp), so the field is marked Stable. The field is still shown, filtered on and edited as before.parseFieldEditRulesreads the flag intoFieldEditRule.notSearchable.deriveTableColumnswritesquac:searchable: false, andreadCollectionFieldEditRulesreads it back.configurationFlagsOfis now the one reader ofconfigurationFlags, for this flag and forHideFromWmsandHideFromWfs.TableColumn, the first-tier examplespec/examples/searchable/, the every-field example, and the regenerated server snapshot.quac:field on a column (declared_fields.json), so the Python needs no change for the field.test_first_tier.pyfilters undeclared fields out.Schema version
The schema moves to
https://vectoriahq.github.io/quac/v0.2.0/schema.json. This covers its$id,QUAC_SCHEMA_URLin the JavaScript and the Python, the spec, the README, the examples and the test catalogues.schema-pages.ymlkeeps each version in its own folder, so thev0.1.0schema stays published unchanged.isNewerQuacMajorcompares only the major version, so a reader built on this release still reads a catalogue that listsv0.1.0, and the reverse holds too.Package version
packages/quac/package.jsonis set to the test version0.2.0-next.1, to be published as a pre-release from this branch. Before merging, set it to0.2.0.Checks
npm test: 833 passed.npm run typecheck: passed.npm run test:server: 55 passed.🤖 Generated with Claude Code