Skip to content

fix(materials): stop losing uploaded files on redeploy (502 on file view) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veniplex merged 1 commit into from
Jul 16, 2026
Merged

fix(materials): stop losing uploaded files on redeploy (502 on file view) #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,9 @@ USER app

EXPOSE 3000
ENV PORT=3000 HOSTNAME=0.0.0.0
# Must match the volume mount in docker-compose.yml. Without this, uploads
# default to `$cwd/data/uploads` (i.e. /app/data/uploads here) — not the
# persisted volume — so files vanish on every container restart/redeploy.
ENV UPLOAD_DIR=/data/uploads

ENTRYPOINT ["sh", "./docker-entrypoint.sh"]
11 changes: 10 additions & 1 deletion src/app/api/materials/[id]/file/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@ export async function GET(
return new Response("Not found", { status: 404 })
}

const size = row.sizeBytes ?? (await fileSize(row.storagePath))
// Confirm the file actually exists on disk before streaming: if it's
// missing (e.g. storage misconfiguration), fail fast with a clean 404
// instead of erroring mid-stream, which surfaces to clients as a broken
// connection / 502 through the reverse proxy.
let size: number
try {
size = await fileSize(row.storagePath)
} catch {
return new Response("Not found", { status: 404 })
}
// Re-sanitize at serve time so rows created before the upload-side
// sanitization can't serve active content either.
const mime = safeInlineMime(row.mimeType)
Expand Down
Loading