Repository navigation
fix(linux): close the "Secret Service read failed" login loop - #67
Merged
Merged
Conversation
On Linux images without the secret-tool binary, every login ended in an endless re-login loop: the missing binary resolved as a vault error, and the fail-closed write path then refused to persist the fresh token anywhere. classifySecretToolLookup now names a missing binary for what it is (there is no vault on the machine, so nothing can be shadowed) and routes it to the documented plaintext fallback, while a vault that ran and failed stays an error. Regression-guarded by 6 new tests; isolated-suite, tsc and behavior probes (exit-2 shim stays fail-closed, ENOENT persists via fallback) all green. Co-Authored-By: Verboo Code <noreply@code.verboo.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secret-toolbinary, every login ended in an endless re-login loop: the missing binary resolved as a vault error, and the fail-closed write path then refused to persist the fresh token anywhere.classifySecretToolLookupnow names a missing binary for what it is (no vault on the machine, so nothing can be shadowed) and routes it to the documented plaintext fallback; a vault that ran and failed stays a fail-closed error.Test plan
src/utils/secureStorage/linuxSecretStorage.test.ts— 6 tests (classifier + missing-binary behavior)bun run test:isolated -- src/utils/secureStorage/— 3/3 PASStsc --noEmitclean on the changed files (repo has ~1722 pre-existing errors elsewhere)missing+ fallback persists/reads back; exit-2 shim → stayserrorfail-closed (no shadow write)🤖 Generated with Verboo Code